To help Mozilla out with this bug, here's the steps: 1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps. 2. [Download and build the Firefox source code](https://firefox-source-docs.mozilla.org/setup/index.html) * If you have any problems, please ask on [Element/Matrix](https://chat.mozilla.org/#/room/#introduction:mozilla.org) in the `#introduction` channel. They're there to help you get started. * You can also read the [Firefox Contributors' Quick Reference](https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html), which has answers to most development questions. 3. Start working on this bug. The DSCard images are decorative and should have an empty alt attribute (`alt=""`) to indicate this to screen readers. A good place to start is [DSImage](https://searchfox.org/firefox-main/source/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/DSImage/DSImage.jsx#280), the React component that renders story card images. Look at the `defaultProps` section (around line 280) - you'll see `alt_text` is currently set to `null`. * If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. 4. Build and test your change according to the [New Tab instructions ](https://firefox-source-docs.mozilla.org/browser/extensions/newtab/docs/index.html). Also check your changes for adherence to our style guidelines by using `mach lint` 5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code. * [Getting your code reviewed](https://firefox-source-docs.mozilla.org/setup/contributing_code.html#getting-your-code-reviewed) * This is when the bug will be assigned to you. 6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide! 7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Bug 1994079 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
To help Mozilla out with this bug, here's the steps: 1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps. 2. [Download and build the Firefox source code](https://firefox-source-docs.mozilla.org/setup/index.html) * If you have any problems, please ask on [Element/Matrix](https://chat.mozilla.org/#/room/#introduction:mozilla.org) in the `#introduction` channel. They're there to help you get started. * You can also read the [Firefox Contributors' Quick Reference](https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html), which has answers to most development questions. 3. Start working on this bug. The DSCard images are decorative and should have an empty alt attribute (`alt=""`) to indicate this to screen readers. A good place to start is [DSImage](https://searchfox.org/firefox-main/source/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/DSImage/DSImage.jsx#280), the React component that renders story card images. Look at the `defaultProps` section (around line 280) - you'll see `alt_text` is currently set to `null`. * If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. 4. Build and test your change according to the [New Tab instructions](https://firefox-source-docs.mozilla.org/browser/extensions/newtab/docs/index.html). Also check your changes for adherence to our style guidelines by using `mach lint` 5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code. * [Getting your code reviewed](https://firefox-source-docs.mozilla.org/setup/contributing_code.html#getting-your-code-reviewed) * This is when the bug will be assigned to you. 6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide! 7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
To help Mozilla out with this bug, here's the steps: 1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps. 2. Download and build the Firefox source code: https://firefox-source-docs.mozilla.org/setup/index.html * If you have any problems, please ask on the bug or reach out to the team. * You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html 3. Start working on this bug. Follow the steps the reporter of this bug has put in to replicate the issue. Use [Developer Tools](https://firefox-source-docs.mozilla.org/devtools-user) to inspect the card image. A good place to start is [DSImage](https://searchfox.org/firefox-main/source/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/DSImage/DSImage.jsx#280), the React component that renders story card images. Look at the `defaultProps` section (around line 280) - you'll see `alt_text` is currently set to `null`. * If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. 4. Run and test your newtab changes: * Open 2 terminal windows, both in the firefox directory: * Window #1: Run `./mach newtab watch` (this will watch for code changes) * Window #2: Run `./mach run` (this will launch Firefox) * To reload the page with fresh code changes: * Mac: Press Cmd+Opt+R * Windows/Linux: Press Ctrl+Shift+R * Check your changes for adherence to our style guidelines by using `./mach lint` 5. Commit your changes with a proper commit message: * Use the following format for your commit message: Bug XXXXXX - Text explaining your fix. r=#home-newtab-reviewers * Replace XXXXXX with the bug number (found at the end of this bug's URL) * Example: Bug 1234567 - Fix broken link in Top Sites menu. r=#home-newtab-reviewers * Commit your changes with: git commit -am "Bug XXXXXX - Your description here. r=#home-newtab-reviewers" * Important: Phabricator only needs one commit per bug. If you need to make additional changes after committing, use `git commit --amend --no-edit` to update your existing commit instead of creating a new one. 6. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code. * Getting your code reviewed: https://firefox-source-docs.mozilla.org/setup/contributing_code.html#getting-your-code-reviewed * This is when the bug will be assigned to you. 7. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide! 8. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
To help Mozilla out with this bug, here's the steps: 1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps. 2. Download and build the Firefox source code: https://firefox-source-docs.mozilla.org/setup/index.html * If you have any problems, please ask on the bug or reach out to the team. * You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html 3. Start working on this bug. Follow the steps the reporter of this bug has put in to replicate the issue. Use [Developer Tools](https://firefox-source-docs.mozilla.org/devtools-user) to inspect the card image. A good place to start is [DSImage](https://searchfox.org/firefox-main/source/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/DSImage/DSImage.jsx#280), the React component that renders story card images. Look at the `defaultProps` section (around line 280) - you'll see `alt_text` is currently set to `null`. * If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. 4. Run and test your newtab changes: * Open 2 terminal windows, both in the firefox directory: * Window #1: Run `./mach newtab watch` (this will watch for code changes) * Window #2: Run `./mach run` (this will launch Firefox) * To reload the page with fresh code changes: * Mac: Press Cmd+Opt+R * Windows/Linux: Press Ctrl+Shift+R * Check your changes for adherence to our style guidelines by using `./mach lint` 5. Commit your changes with a proper commit message: * Use the following format for your commit message: Bug XXXXXX - Text explaining your fix. r=#home-newtab-reviewers * Replace XXXXXX with the bug number (found at the end of this bug's URL) * Example: Bug 1234567 - Fix broken link in Top Sites menu. r=#home-newtab-reviewers * Commit your changes with: git commit -am "Bug XXXXXX - Your description here. r=#home-newtab-reviewers" * Important: Phabricator only needs one commit per bug. If you need to make additional changes after committing, use `git commit --amend --no-edit` to update your existing commit instead of creating a new one. 6. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code. * Getting your code reviewed: https://firefox-source-docs.mozilla.org/setup/contributing_code.html#getting-your-code-reviewed * This is when the bug will be assigned to you. 7. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide! 8. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.