Bug 1997503 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I'd suggest stepping through the code emitted by `emitPreBarrierFastPath` to see if the instructions do what you'd expect.

Skimming the code quickly, I noticed that `unboxGCThingForGCBarrier` calls `ExtractBits` with `JSVAL_TAG_SHIFT - 1`. Is that right or should it be just `JSVAL_TAG_SHIFT`?
Revision 1 by
on 
I'd suggest stepping through the code emitted by `emitPreBarrierFastPath` to see if the instructions do what you'd expect.

Skimming the code quickly, I noticed that `unboxGCThingForGCBarrier` for riscv calls `ExtractBits` with `JSVAL_TAG_SHIFT - 1`. Is that right or should it be just `JSVAL_TAG_SHIFT`?

Back to Bug 1997503 Comment 4