> I'm taking a look into what we could do on the AboutNewTabResourceMapping.sys.mjs side to handles these edge cases more gracefully, which I think should also mitigate the issue hit with the "Firefox profile relocated" scenario. Does this part "should also mitigate the issue hit with the "Firefox profile relocated" scenario", does this mean the fixes in [D286884](https://phabricator.services.mozilla.com/D286884) do not fix the backup/restore path in about:settings#sync? > if the XPI file has been removed or if it corrupted and we are unable to read the assets packaged in the zip file (e.g. faulty disk/filesystem) > These edge cases would not be handled by Bug 1429838, but would lead to a similar outcome. This is probably fine, as long as it's fixing the backup/restore path in about:settings#sync, I think the edge cases are less urgent. > If the approach will feel reasonable and low risky, that may be what we may consider requesting an uplift for 149 beta If it's too risky, could we consider a very small less risky fix just for this case?
Bug 2007810 Comment 19 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> I'm taking a look into what we could do on the AboutNewTabResourceMapping.sys.mjs side to handles these edge cases more gracefully, which I think should also mitigate the issue hit with the "Firefox profile relocated" scenario. Does this part "should also mitigate the issue hit with the "Firefox profile relocated" scenario", does this mean the fixes in [D286884](https://phabricator.services.mozilla.com/D286884) do not fix the backup/restore path in about:settings#sync? > if the XPI file has been removed or if it corrupted and we are unable to read the assets packaged in the zip file (e.g. faulty disk/filesystem) > These edge cases would not be handled by Bug 1429838, but would lead to a similar outcome. This is probably fine, as long as it's fixing the backup/restore path in about:settings#sync, I think the edge cases are less urgent. > If the approach will feel reasonable and low risky, that may be what we may consider requesting an uplift for 149 beta If it's too risky, could we consider a very small less risky fix just for this case?
> I'm taking a look into what we could do on the AboutNewTabResourceMapping.sys.mjs side to handles these edge cases more gracefully, which I think should also mitigate the issue hit with the "Firefox profile relocated" scenario. Does this part "should also mitigate the issue hit with the "Firefox profile relocated" scenario", does this mean the fixes in [D286884](https://phabricator.services.mozilla.com/D286884) do not fix the backup/restore path in about:settings#sync? > if the XPI file has been removed or if it corrupted and we are unable to read the assets packaged in the zip file (e.g. faulty disk/filesystem) > These edge cases would not be handled by Bug 1429838, but would lead to a similar outcome. This is probably fine, as long as it's fixing the backup/restore path in about:settings#sync, I think the edge cases are less urgent. > If the approach will feel reasonable and low risky, that may be what we may consider requesting an uplift for 149 beta If it's too risky, could we consider a very small less risky fix just for this case, along side the larger more complete more risky patch?