Bug 2016440 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I've been thinking about this some more today and another middle ground approach may be to:

- to not use an AsyncShutdown blocker anyone on the AboutNewTabResourceMapping side (as mentioned in comment 4), but to also add logic to bail out instead of calling newInstall.continuePostponedInstall by checking explicitly if Services.startup.attemptingQuit is true in the onInstallPostponed (similar to the diff at the end of comment 5)

- and to leave to the AsyncShutdown blockers on the XPIProvider side the responsability to deal with the XPIProvider's operations that may still be in progress while we are about to shutdown.
Revision 1 by
on 
I've been thinking about this some more today and another middle ground approach may be to:

- to not use an AsyncShutdown blocker anymore on the AboutNewTabResourceMapping side (as mentioned in comment 4), but to also add logic to bail out instead of calling newInstall.continuePostponedInstall by checking explicitly if Services.startup.attemptingQuit is true in the onInstallPostponed (similar to the diff at the end of comment 5)

- and to leave to the AsyncShutdown blockers on the XPIProvider side the responsability to deal with the XPIProvider's operations that may still be in progress while we are about to shutdown.

Back to Bug 2016440 Comment 7