Bug 2023464 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Daniel Holbert [:dholbert] from comment #3)
> (I didn't bother testing in older builds with the pref manually enabled.)

OK, I did that^ now -- bisecting with `browser.newtabpage.activity-stream.discoverystream.reportContent.enabled:true` and `browser.newtabpage.activity-stream.discoverystream.reportAds.enabled:true`.

Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5bb6f98466b7a3e8d2f92e0c3ab4c18bd969b826&tochange=80e53238ba81917e9b85d7511c55021ebf8407bf

Before that range, the dialog is only ever shown on the tab where I summoned it, as you'd expect.

--> This was a regression from bug 1954656.  (That's interesting since bug 1954656 was ostensibly just about adding telemetry; but it apparently changed our actual user-facing behavior as well, probably by accident.)

Reem, maybe you could you take a look?
(In reply to Daniel Holbert [:dholbert] from comment #3)
> (I didn't bother testing in older builds with the pref manually enabled.)

OK, I did that^ now -- bisecting with `browser.newtabpage.activity-stream.discoverystream.reportContent.enabled:true` and `browser.newtabpage.activity-stream.discoverystream.reportAds.enabled:true`.

Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5bb6f98466b7a3e8d2f92e0c3ab4c18bd969b826&tochange=80e53238ba81917e9b85d7511c55021ebf8407bf

Before that range, the dialog is only ever shown on the tab where I summoned it, as you'd expect.
After that range, the dialog unexpectedly reappears when you open additional new tabs (beyond the first which I suspect is preloaded).

--> This was a regression from bug 1954656.  (That's interesting since bug 1954656 was ostensibly just about adding telemetry; but it apparently changed our actual user-facing behavior as well, probably by accident.)

Reem, maybe you could you take a look?
(In reply to Daniel Holbert [:dholbert] from comment #3)
> (I didn't bother testing in older builds with the pref manually enabled.)

OK, I did that^ now -- bisecting with `browser.newtabpage.activity-stream.discoverystream.reportContent.enabled:true` and `browser.newtabpage.activity-stream.discoverystream.reportAds.enabled:true`.

Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5bb6f98466b7a3e8d2f92e0c3ab4c18bd969b826&tochange=80e53238ba81917e9b85d7511c55021ebf8407bf

Before that range, the dialog is only ever shown on the tab where I summoned it, as you'd expect.
After that range, the dialog unexpectedly reappears when you open several additional new tabs.

--> This was a regression from bug 1954656.  (That's interesting since bug 1954656 was ostensibly just about adding telemetry; but it apparently changed our actual user-facing behavior as well, probably by accident.)

Reem, maybe you could you take a look?
(In reply to Daniel Holbert [:dholbert] from comment #3)
> (I didn't bother testing in older builds with the pref manually enabled.)

OK, I did that^ now -- bisecting with `browser.newtabpage.activity-stream.discoverystream.reportContent.enabled:true` and `browser.newtabpage.activity-stream.discoverystream.reportAds.enabled:true`.

Regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5bb6f98466b7a3e8d2f92e0c3ab4c18bd969b826&tochange=80e53238ba81917e9b85d7511c55021ebf8407bf

Before that range, the dialog is only ever shown on the tab where I summoned it, as you'd expect.
After that range, the dialog unexpectedly appears on unrelated new-tabs, when you open several additional new tabs, as shown in the attached screencast.

--> This was a regression from bug 1954656.  (That's interesting since bug 1954656 was ostensibly just about adding telemetry; but it apparently changed our actual user-facing behavior as well, probably by accident.)

Reem, maybe you could you take a look?

Back to Bug 2023464 Comment 4