There's a separate question about whether we should consider these APIs to be dead-code and remove them. `getBoxQuads` at least has internal usages in Firefox frontend code, as I noted in the commit message [and those will remain working]. But `convert*FromNode` is only used in tests as far as I can tell: https://searchfox.org/firefox-main/search?q=convert.*FromNode&path=&case=false®exp=true ) So maybe it might be worth removing the `convert*FromNode` APIs down the line. But for the purposes of this bug, I'm just focused on the pref-enablement situation.
Bug 2026051 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
There's a separate question about whether we should consider these APIs to be dead-code and remove them. `getBoxQuads` at least has internal usages in Firefox frontend code, as I noted in the commit message (and those will remain working regardless of the pref value). `convert*FromNode` is only used in tests as far as I can tell: https://searchfox.org/firefox-main/search?q=convert.*FromNode&path=&case=false®exp=true ) So maybe it might be worth removing the `convert*FromNode` APIs down the line. But for the purposes of this bug, I'm just focused on the pref-enablement situation.
There's a separate question about whether we should consider these APIs to be dead-code and remove them. `getBoxQuads` at least has internal usages in Firefox frontend code, as I noted in the commit message (and those will remain working regardless of the pref value). `convert*FromNode` is only used in tests as far as I can tell: https://searchfox.org/firefox-main/search?q=convert.*FromNode&path=&case=false®exp=true So maybe it might be worth removing the `convert*FromNode` APIs down the line. But for the purposes of this bug, I'm just focused on the pref-enablement situation.