Bugzilla

With `browser.design-tokens.nova` set to `true`, the extensions button icon seems to be cropped off.

Based on a quick look into the CSS rules tied to the nova pref, it seems to be a side effect on the `--badge-border-radius` variable being overridden with `--border-radius-circle` (corresponding to `9999px`) [here in moz-badge.tokens.css](https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/toolkit/content/widgets/moz-badge/moz-badge.tokens.css#46) from the current `--border-radius-small` (corresponding to `4px`) (which is instead set [here in the same moz-badge.tokens.css](https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/toolkit/content/widgets/moz-badge/moz-badge.tokens.css#17)), and inherited by the toolbar button and the toolbar button icon inside through https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/browser/themes/shared/toolbarbuttons.css#145.

This bugzilla issue is tracking looking into that and determine what should be tweaked to make sure the extensions button icon isn't cropped when Nova design tokens rules are enabled.

As a side note, along with looking into the issue with the extensions button icon specifically, we should also assess if there will be a similar impact on some extension toolbar button icons (the uBlock icon doesn't seem to be impacted, but it would be worth double-check that it is not just because the shape of the icon doesn't make it visible and so for other extension icons to be potentially impacted instead).

With `browser.nova.enabled` set to `true` (or `browser.design-tokens.nova` set to `true` in older nightly versions), the extensions button icon seems to be cropped off.

Based on a quick look into the CSS rules tied to the nova pref, it seems to be a side effect on the `--badge-border-radius` variable being overridden with `--border-radius-circle` (corresponding to `9999px`) [here in moz-badge.tokens.css](https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/toolkit/content/widgets/moz-badge/moz-badge.tokens.css#46) from the current `--border-radius-small` (corresponding to `4px`) (which is instead set [here in the same moz-badge.tokens.css](https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/toolkit/content/widgets/moz-badge/moz-badge.tokens.css#17)), and inherited by the toolbar button and the toolbar button icon inside through https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/browser/themes/shared/toolbarbuttons.css#145.

This bugzilla issue is tracking looking into that and determine what should be tweaked to make sure the extensions button icon isn't cropped when Nova design tokens rules are enabled.

As a side note, along with looking into the issue with the extensions button icon specifically, we should also assess if there will be a similar impact on some extension toolbar button icons (the uBlock icon doesn't seem to be impacted, but it would be worth double-check that it is not just because the shape of the icon doesn't make it visible and so for other extension icons to be potentially impacted instead).