Bug 2040638 Comment 39 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Francesco from comment #38)
> Thanks, this works now. I cancelled sending of a big message and the cancel itself as well as the resending both worked.
> Next I tried to forward a large message, which is the scenario that creates the temporary attachments. I watched those in the temp directory. Upon first cancel, the temporary attachments were maintained. Once the message was abandoned, they were deleted.
> 
> I was actually going to set the status to VERIFIED, but the bug isn't marked as fixed yet. Will you be adding a test since this is not the first time the function broke?

Thank you for the kind feedback.

My test suite exceeds 1000 LOC and is not really of my quality or really any quality standard, yet.

You can inspect them here: https://hg-edge.mozilla.org/try-comm-central/rev/30512948de139903ba13b770c5c889801797f4ce
(In reply to Francesco from comment #38)
> Thanks, this works now. I cancelled sending of a big message and the cancel itself as well as the resending both worked.
> Next I tried to forward a large message, which is the scenario that creates the temporary attachments. I watched those in the temp directory. Upon first cancel, the temporary attachments were maintained. Once the message was abandoned, they were deleted.
> 
> I was actually going to set the status to VERIFIED, but the bug isn't marked as fixed yet. Will you be adding a test since this is not the first time the function broke?

Thank you for the kind feedback.

My test suite exceeds 1000 LOC and is not really of my or really anyones quality standard, yet.

You can inspect the tests here: https://hg-edge.mozilla.org/try-comm-central/rev/30512948de139903ba13b770c5c889801797f4ce
(In reply to Francesco from comment #38)
> Thanks, this works now. I cancelled sending of a big message and the cancel itself as well as the resending both worked.
> Next I tried to forward a large message, which is the scenario that creates the temporary attachments. I watched those in the temp directory. Upon first cancel, the temporary attachments were maintained. Once the message was abandoned, they were deleted.
> 
> I was actually going to set the status to VERIFIED, but the bug isn't marked as fixed yet. Will you be adding a test since this is not the first time the function broke?

Thank you for the kind feedback.

My test suite exceeds 1000 LOC and is not really of my or really anyones quality standard, yet.

You can inspect the tests here: https://hg-edge.mozilla.org/try-comm-central/rev/657644173fc4fcc061d58fc626f22f07540c6277

Back to Bug 2040638 Comment 39