My 2 cents here. I originally started with `MenuItemDefaults`, which only consolidated the colors for the MenuItem. At some point, I got a bit lost in consolidating things and turned `MenuItemDefaults` to `MenuDefaults`. I got to point where I edited the original bug description to say this is now more of a exploration and throwing ideas out there to get feedback and see what stick. I like the idea of consolidating a per-component level here instead of what I tried to do which was consolidated the whole Menu component in one. This would align more along with M3 pattern of having defaults per component like `ButtonDefaults` and `SwitchDefaults`. This will still be an incremental improvement. One caveat here is that I don't want us over-inflate the scope, but be able to provide incremental steps toward that end goal that we might happy with it because we are not using this bug to overhaul everything.
Bug 2043465 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
My 2 cents here. I originally started with `MenuItemDefaults`, which only consolidated the colors for the MenuItem. At some point, I got a bit lost in consolidating things and turned `MenuItemDefaults` to `MenuDefaults`. I got to point where I edited the original bug description to say this is now more of a exploration and throwing ideas out there to get feedback and see what stick. I like the idea of consolidating a per-component level here instead of what I tried to do which was consolidated the whole Menu component in one. This would align more along with M3 pattern of having defaults per component like `ButtonDefaults` and `SwitchDefaults`. This will still be an incremental improvement. One caveat here is that I don't want us over-inflate the scope, but be able to provide incremental steps toward that end goal that we might happy with it because we are not using this bug to overhaul everything. Even though I found that there are opportunities to overhaul things, but it's likely need to happen incrementally.
My 2 cents here. I originally started with `MenuItemDefaults`, which only consolidated the colors for the MenuItem. At some point, I got a bit lost in consolidating things and turned `MenuItemDefaults` to `MenuDefaults`. I got to point where I edited the original bug description to say this is now more of a exploration and throwing ideas out there to get feedback and see what stick. I like the idea of consolidating a per-component level here instead of what I tried to do which was consolidated the whole Menu component in one. This would align more along with M3 pattern of having defaults per component like `ButtonDefaults` and `SwitchDefaults`. This will still be an incremental improvement. One caveat here is that I don't want us over-inflate the scope, but be able to provide incremental steps toward that end goal that we might happy with because we are not using this bug to overhaul everything. Even though I found that there are opportunities to overhaul things, but it's likely need to happen incrementally.