With the transition to Nova, UX has removed the icons that appear within the Downloads details dialog that is available for blocked downloads. Temporarily, this was handled with `display: none` behind the nova pref. However, the best way to remove the dated styles once Nova is rolled out. See - https://searchfox.org/firefox-main/rev/7fa9b602777418732e08b26d1ef6c9945c4bbd72/browser/themes/shared/downloads/download-blockedStates.css#13-27,43-50 Note that the icons still need to appear within the Downloads panel, so the rule should be modified from this: ``` #downloadsPanel-blockedSubview[verdict="Insecure"] .downloadsPanel-blockedSubview-image, #downloadsPanel-blockedSubview[verdict="Malware"] .downloadsPanel-blockedSubview-image, #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` to this, for example: ``` #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ```
Bug 2056428 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
**Remove code for Blocked Subview Icons** With the transition to Nova, UX has removed the icons that appear within the Downloads details dialog that is available for blocked downloads. Temporarily, this was handled with `display: none` behind the nova pref. However, the best way to remove the dated styles once Nova is rolled out. See - https://searchfox.org/firefox-main/rev/7fa9b602777418732e08b26d1ef6c9945c4bbd72/browser/themes/shared/downloads/download-blockedStates.css#13-27,43-50 Note that the icons still need to appear within the Downloads panel, so the rule should be modified from this: ``` #downloadsPanel-blockedSubview[verdict="Insecure"] .downloadsPanel-blockedSubview-image, #downloadsPanel-blockedSubview[verdict="Malware"] .downloadsPanel-blockedSubview-image, #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` to this, for example: ``` #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` **Remove "not Nova" code in downloads.inc.css** There's a few lines of code that target the pre-Nova version of the panel and subview. This code can be removed. **Stylesheet cleanup** At some point over the years, code specifically for the blocked subview made it into `downloads.inc.css`. Since there is an entire stylesheet dedicated to the blocked subview, `download-blockedStates.css`, it makes sense to keep all blocked subview code there. Move any code specific to the blocked subview from `downloads.inc.css` to `download-blockedStates.css`.
**Remove code for Blocked Subview Icons** With the transition to Nova, UX has removed the icons that appear within the Downloads details dialog that is available for blocked downloads. Temporarily, this was handled with `display: none` behind the nova pref. However, the best way to remove the dated styles once Nova is rolled out. See - https://searchfox.org/firefox-main/rev/7fa9b602777418732e08b26d1ef6c9945c4bbd72/browser/themes/shared/downloads/download-blockedStates.css#13-27,43-50 Note that the icons still need to appear within the Downloads panel, so the rule should be modified from this: ``` #downloadsPanel-blockedSubview[verdict="Insecure"] .downloadsPanel-blockedSubview-image, #downloadsPanel-blockedSubview[verdict="Malware"] .downloadsPanel-blockedSubview-image, #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` to this, for example: ``` #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` **Remove "not Nova" code in downloads.inc.css** There's a few lines of code that target the pre-Nova version of the panel and subview. This code can be removed. **Stylesheet cleanup** At some point over the years, code specifically for the blocked subview made it into `downloads.inc.css`. Since there is an entire stylesheet dedicated to the blocked subview, `download-blockedStates.css`, it makes sense to keep all blocked subview code there. Move any code specific to the blocked subview from `downloads.inc.css` to `download-blockedStates.css`. Merge any rules, where applicable.
**Remove code for Blocked Subview Icons** With the transition to Nova, UX has removed the icons that appear within the Downloads details dialog that is available for blocked downloads. Temporarily, this was handled with `display: none` behind the nova pref. However, the best way to remove the dated styles once Nova is rolled out. See - https://searchfox.org/firefox-main/rev/7fa9b602777418732e08b26d1ef6c9945c4bbd72/browser/themes/shared/downloads/download-blockedStates.css#13-27,43-50 Note that the icons still need to appear within the Downloads panel, so the rule should be modified from this: ``` #downloadsPanel-blockedSubview[verdict="Insecure"] .downloadsPanel-blockedSubview-image, #downloadsPanel-blockedSubview[verdict="Malware"] .downloadsPanel-blockedSubview-image, #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` to this, for example: ``` #downloadsListBox > richlistitem[verdict="Insecure"] .downloadBlockedBadge, #downloadsListBox > richlistitem[verdict="Malware"] .downloadBlockedBadge { background-image: url("chrome://global/skin/icons/error.svg"); -moz-context-properties: fill; fill: var(--icon-color-critical); } ``` **Remove "not Nova" code in downloads.inc.css** There's a few lines of code that target the pre-Nova version of the panel and subview. This code can be removed.