Bug 543435 Comment 187 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Vincent Hilla [:vhilla] from comment #185)
> I'm a bit stuck on [browser_firstPartyIsolation_js_uri.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_js_uri.js). This test loads `javascript:0;` but [browser_firstPartyIsolation_aboutPages.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js) is also failing with `about:blank`.

This seems related to [browser_hwconcurrency_popups_aboutblank.js](https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/browser_hwconcurrency_popups_aboutblank.js). The test is a bit lengthy, but I got a simplified version. In a page exempted from RFP, open an about:blank popup and `eval(navigator.hardwareConcurrency)`. With this patch, it's incorrectly spoofed. From pernosco, `Document::mShouldResistFingerprinting` is incorrectly true as we don't call `RecomputeResistFingerprinting` during the sync `about:blank` load, or update the principal at all.
Revision 1 by
on 
(In reply to Vincent Hilla [:vhilla] from comment #185)
> I'm a bit stuck on [browser_firstPartyIsolation_js_uri.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_js_uri.js). This test loads `javascript:0;` but [browser_firstPartyIsolation_aboutPages.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js) is also failing with `about:blank`.

This seems related to [browser_hwconcurrency_popups_aboutblank.js](https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/browser_hwconcurrency_popups_aboutblank.js). The test is a bit lengthy, but I got a simplified version. In a page exempted from RFP, open an about:blank popup and `eval(navigator.hardwareConcurrency)`. With this patch, it's incorrectly spoofed. From pernosco, `Document::mShouldResistFingerprinting` is incorrectly true as we don't call `RecomputeResistFingerprinting` during the sync `about:blank` load, or update the principal at all.

Edit: fixed by doing `Document::SetContainer` slightly earlier.
Revision 2 by
on 
(In reply to Vincent Hilla [:vhilla] from comment #185)
> I'm a bit stuck on [browser_firstPartyIsolation_js_uri.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_js_uri.js). This test loads `javascript:0;` but [browser_firstPartyIsolation_aboutPages.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js) is also failing with `about:blank`.

This seems related to [browser_hwconcurrency_popups_aboutblank.js](https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/browser_hwconcurrency_popups_aboutblank.js). The test is a bit lengthy, but I got a simplified version. In a page exempted from RFP, open an about:blank popup and `eval(navigator.hardwareConcurrency)`. With this patch, it's incorrectly spoofed. From pernosco, `Document::mShouldResistFingerprinting` is incorrectly true as we don't call `RecomputeResistFingerprinting` during the sync `about:blank` load, or update the principal at all.

Edit: hwconcurrency fixed by doing `Document::SetContainer` slightly earlier.
Revision 3 by
on 
(In reply to Vincent Hilla [:vhilla] from comment #185)
> I'm a bit stuck on [browser_firstPartyIsolation_js_uri.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_js_uri.js). This test loads `javascript:0;` but [browser_firstPartyIsolation_aboutPages.js](https://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js) is also failing with `about:blank`.

~~This seems related to [browser_hwconcurrency_popups_aboutblank.js](https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/browser_hwconcurrency_popups_aboutblank.js). The test is a bit lengthy, but I got a simplified version. In a page exempted from RFP, open an about:blank popup and `eval(navigator.hardwareConcurrency)`. With this patch, it's incorrectly spoofed. From pernosco, `Document::mShouldResistFingerprinting` is incorrectly true as we don't call `RecomputeResistFingerprinting` during the sync `about:blank` load, or update the principal at all.~~

Edit: hwconcurrency fixed by doing `Document::SetContainer` slightly earlier.

Back to Bug 543435 Comment 187