Review of attachment 9157474 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/addrbook/content/abCardDAVDialog.js @@ +97,5 @@ > + async function tryURL(url) { > + console.log(`Attempting to connect to ${url}`); > + response = await CardDAVDirectory.makeRequest(url, requestParams); > + if (response.status == 207 && response.dom) { > + console.log("\u2026 success"); we may want to stick to dot dot dot for debugs :) Anyway, I'd add the url to the message to make it easer to debug (could be long away from the original in some situations) ::: mailnews/addrbook/content/abCardDAVDialog.xhtml @@ +53,2 @@ > <html:td class="input-container"> > + <html:input id="carddav-url" type="text" Why change it to text? With url you get the instant validation and trimming of the value. You could instead prefix https:// onoblur as needed. Could also add required="required". I notice you just give blank value to continue (failing) at the moment. ::: mailnews/addrbook/test/CardDAVServer.jsm @@ +116,5 @@ > }, > > + ping(request, response) { > + response.setStatusLine("1.1", 200, "OK"); > + response.write("pong"); Is the response content type output automatically for cases like these? If not, we should add that.
Bug 546932 Comment 148 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9157474 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/addrbook/content/abCardDAVDialog.js @@ +97,5 @@ > + async function tryURL(url) { > + console.log(`Attempting to connect to ${url}`); > + response = await CardDAVDirectory.makeRequest(url, requestParams); > + if (response.status == 207 && response.dom) { > + console.log("\u2026 success"); we may want to stick to dot dot dot for debugs :) Anyway, I'd add the url to the message to make it easer to debug (could be long away from the original in some situations) ::: mailnews/addrbook/content/abCardDAVDialog.xhtml @@ +53,2 @@ > <html:td class="input-container"> > + <html:input id="carddav-url" type="text" Why change it to text? With url you get the instant validation and trimming of the value. You could instead prefix https:// onblur as needed. Could also add required="required". I notice you just give blank value to continue (failing) at the moment. ::: mailnews/addrbook/test/CardDAVServer.jsm @@ +116,5 @@ > }, > > + ping(request, response) { > + response.setStatusLine("1.1", 200, "OK"); > + response.write("pong"); Is the response content type output automatically for cases like these? If not, we should add that.