LGTM Previous comments from version 0.1 seem all the be addressed. A few notes/NITs: > Lets small icons be used in Composer / Text Editor for Classic Theme In Modern gives you a small SeaMonkey throbber and normal composer icons. Add small Modern icons in a follow-up I think. > editor/ui/composer/content/editorOverlay.xul > - <command id="cmd_viewCompToolbar" oncommand="goToggleToolbar('EditToolbar','cmd_viewCompToolbar');" checked="true"/> While we touch the code I would reformat and line up vertically. Formatting in the XUL files in now inconsistent but you probably know and want to prerserve "BLAME". This would need a full reformat and can be done later when the codebase in better shape.
Bug 606683 Comment 52 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
LGTM Previous comments from version 0.1 seem all the be addressed. A few notes/NITs: > Lets small icons be used in Composer / Text Editor for Classic Theme In Modern gives you a small SeaMonkey throbber and normal composer icons. Add small Modern icons in a follow-up I think. > editor/ui/composer/content/editorOverlay.xul > - <command id="cmd_viewCompToolbar" oncommand="goToggleToolbar('EditToolbar','cmd_viewCompToolbar');" checked="true"/> While we touch the code I would reformat and line up vertically. Edit 28.04. Given that it was a removal ignore and lets leave the line below alone. Formatting in the XUL files in now inconsistent but you probably know and want to prerserve "BLAME". This would need a full reformat and can be done later when the codebase in better shape.