The failures is caused by part 1, since now the signature of `requestFullscreen()` is changed to have `FullscreenOption` argument, which results in `requestFullscreen(123)` rejecting the promise. Other browsers also reject the promise in such case, since they all have `FullscreenOption` argument now. There is a wpt test, https://wpt.fyi/results/fullscreen/api/element-request-fullscreen-options.html?label=experimental&label=master&aligned, but the test actually doesn't test the invalid argument properly, because the `requestFullscreen()` always rejects the promise due to the lack of user activation. I fix the test and also extended it to cover additional invalid argument cases. Will land the patches again soon.
Bug 700123 Comment 32 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The failures is caused by part 1, since now the signature of `requestFullscreen()` is changed to have `FullscreenOption` argument, which results in `requestFullscreen(123)` rejecting the promise now. Other browsers also reject the promise in such case, since they all have `FullscreenOption` argument support. There is a wpt test, https://wpt.fyi/results/fullscreen/api/element-request-fullscreen-options.html?label=experimental&label=master&aligned, but the test actually doesn't test the invalid argument properly, because the `requestFullscreen()` always rejects the promise due to the lack of user activation. I fix the test and also extended it to cover additional invalid argument cases. Will land the patches again soon.
The failures is caused by part 1, since now the signature of `requestFullscreen()` is changed to have `FullscreenOption` argument, which results in `requestFullscreen(123)` rejecting the promise now. Other browsers also reject the promise in such case, since they all have `FullscreenOption` argument support. There is a wpt test, https://wpt.fyi/results/fullscreen/api/element-request-fullscreen-options.html?label=experimental&label=master&aligned, but the test actually doesn't test the invalid argument properly, because the `requestFullscreen()` always rejects the promise due to the lack of user activation. I fixed the test and also extended it to cover additional invalid argument cases. Will land the patches again soon.