Bugzilla

Sorry for the confusion; I was referring to line 506 of the quotaroot-fix3.diff attachment but you found the right place.
Anyhow, thanks for wake-up on "this" meaning.  So I didn't have to declare a "quotaItem" at all, just set the values into the folder object using the new "set" methods.

I have an array of nsIMsgQuota items that I defined in the  folder .h file:

 nsCOMArray<nsIMsgQuota> m_folderQuota;

I set the 3 values into the folder object then then append an element to m_folderQuota array:

    SetQuotaRootResource(aFolderQuotaRoot);
    SetResourceUsed(aFolderQuotaUsed);
    SetResourceMax(aFolderQuotaMax);
    m_folderQuota.AppendElement(this);

Is this correct? It seems strange to append "this" at this point, but it seems to work. 

I fixed the "keys" and display empty when there is no quotaroot name as requested in comment 17.  Also, I assume the string changes are needed in the "suite" so I made the corresponding changes there too. And got rid of the printfs. 

I'll submit the formal patch with the appropriate headers if this is OK and after a bit more testing.

Sorry for the confusion; I was referring to line 506 of the quotaroot-fix3.diff attachment but you found the right place.
Anyhow, thanks for wake-up on "this" meaning.  So I didn't have to declare a "quotaItem" at all, just set the values into the folder object using the new "set" methods.

I have an array of nsIMsgQuota items that I defined in the  folder .h file:

 nsCOMArray<nsIMsgQuota> m_folderQuota;

I set the 3 values into the folder object then then append an element to m_folderQuota array:

    SetQuotaRootResource(aFolderQuotaRoot);
    SetResourceUsed(aFolderQuotaUsed);
    SetResourceMax(aFolderQuotaMax);
    m_folderQuota.AppendElement(this);

Is this correct? It seems strange to append "this" at this point, but it seems to work. 

I fixed the "keys" and display empty when there is no quotaroot name as requested in comment 17.  Also, I assume the string changes are needed in the "suite" so I made the corresponding changes there too. And got rid of the printfs. 

I'll submit the formal patch with the appropriate headers if this is OK and after a bit more testing.
Edit: And will run clang-format.