Bug 971347 Comment 256 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Landed with the following linting errors fixed.
```
  1085:5   error  Extra space after key 'onProxyAvailable'.  key-spacing (eslint)
  1085:5   error  Expected method shorthand.                 object-shorthand (eslint)
  1091:28  error  Missing semicolon.                         semi (eslint)
  1092:6   error  Missing trailing comma.                    comma-dangle (eslint)
  1097:13  error  newURI's last parameters are optional.     mozilla/no-useless-parameters (eslint)
```

Author and reviewer **MUST** always run linting before submitting patches.

Just keep in mind that none of these patches would have been accepted for mozilla-central. Anything that doesn't cleanly apply or causes linting errors is rejected immediately. You're very lucky to have the (grumpy) comm-central sheriffing service which also serves as a clean-up maid for everyone :-(
Revision 1 by
on 
Landed with the following linting errors fixed.
```
  1085:5   error  Extra space after key 'onProxyAvailable'.  key-spacing (eslint)
  1085:5   error  Expected method shorthand.                 object-shorthand (eslint)
  1091:28  error  Missing semicolon.                         semi (eslint)
  1092:6   error  Missing trailing comma.                    comma-dangle (eslint)
  1097:13  error  newURI's last parameters are optional.     mozilla/no-useless-parameters (eslint)
```

Author and reviewer **MUST** always run linting before submitting or approving patches.

Just keep in mind that none of these patches would have been accepted for mozilla-central. Anything that doesn't cleanly apply or causes linting errors is rejected immediately. You're very lucky to have the (grumpy) comm-central sheriffing service which also serves as a clean-up maid for everyone :-(

Back to Bug 971347 Comment 256