Bug 1222046 Comment 66 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Here's another try at fixing this. The affected code occurs while writing the temp file containing the message to be sent. There is already attempts in this code to ensure a CRLF ending but sometimes, obviously, it doesn't work. So as each line is written to the file, I check the ending for CRLF and if it is not found on the last write, I force a write of CRLF. However, when the line is written encrypted, I assume the CRLF is present so this should preclude a problem.

This fixes the bug as reported and also passes the tests under mailnews/compose/test/unit/ including the long lines test that failed before. (FWIW, the v0 diff also passes the tests.)
Here's another try at fixing this. The affected code occurs while writing the temp file containing the message to be sent. There are already attempts in this code to ensure a CRLF ending but sometimes, obviously, it doesn't work. So as each line is written to the file, I check the ending for CRLF and if it is not found on the last write, I force a write of CRLF. However, when the line is written encrypted, I assume the CRLF is present so this should preclude a problem.

This fixes the bug as reported and also passes the tests under mailnews/compose/test/unit/ including the long lines test that failed before. (FWIW, the v0 diff also passes the tests.)

Back to Bug 1222046 Comment 66