Bug 1243121 Comment 56 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

After the previous patch is applied, then I get the following error.

This patches solves the error.

``
/usr/bin/ccache /usr/bin/g++-10 -std=gnu++17 -o Unified_cpp_mozglue_baseprofiler0.o -c  -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/stl_wrappers -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/system_wrappers -include /NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DIMPL_MFBT -DMOZ_VTUNE_INSTRUMENTATION -DIMPL_MFBT -DMOZ_HAS_MOZGLUE -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/baseprofiler -I/NEW-SSD/moz-obj-dir/objdir-tb3/mozglue/baseprofiler -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/baseprofiler/core -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/linker -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nspr -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /NEW-SSD/moz-obj-dir/objdir-tb3/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++2a-compat -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -Wno-psabi -fno-sized-deallocation -fno-aligned-new -fno-builtin-strlen -Wl,--gdb-index -Dfdatasync=fdatasync -DDEBUG_4GB_CHECK -DUSEHELGRIND=1 -DUSEVALGRIND=1 -DDEBUG -g -gsplit-dwarf -Werror=sign-compare -Werror=unused-result -Werror=unused-variable -Werror=format -fuse-ld=gold -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -g -Og -fvar-tracking -gdwarf-4 -fvar-tracking-assignments -freorder-blocks -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow -Wno-ignored-qualifiers  -MD -MP -MF .deps/Unified_cpp_mozglue_baseprofiler0.o.pp  -fdiagnostics-color  Unified_cpp_mozglue_baseprofiler0.cpp
In file included from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap.h:47,
                 from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/ldap-int.h:87,
                 from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:39:
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c: In function ‘ldap_utf8strtok_r’:
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:816:71: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  816 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc((const char**)&s) : *s++)
      |                                                                       ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:185:8: note: in expansion of macro ‘LDAP_UTF8GETC’
  185 |   sc = LDAP_UTF8GETC(sp);
      |        ^~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:814:57: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  814 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc(&s) : *s++)
      |                                                         ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:186:24: note: in expansion of macro ‘LDAP_UTF8GETCC’
  186 |   for (bp = brk; (bc = LDAP_UTF8GETCC(bp)) != 0;) {
      |                        ^~~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:816:71: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  816 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc((const char**)&s) : *s++)
      |                                                                       ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:200:10: note: in expansion of macro ‘LDAP_UTF8GETC’
  200 |     sc = LDAP_UTF8GETC(sp);
      |          ^~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:814:57: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  814 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc(&s) : *s++)
      |                                                         ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:203:17: note: in expansion of macro ‘LDAP_UTF8GETCC’
  203 |       if ((bc = LDAP_UTF8GETCC(bp)) == sc) {
      |                 ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
gmake[4]: *** [/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/rules.mk:597: utf8.o] Error 1
gmake[4]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/ldap/c-sdk/libraries/libldap'
gmake[3]: *** [/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/recurse.mk:72: comm/ldap/c-sdk/libraries/libldap/target-objects] Error 2
gmake[3]: *** Waiting for unfinished jobs....

```
After the previous patch is applied, then I get the following error.

This patches solves the error.

```
/usr/bin/ccache /usr/bin/g++-10 -std=gnu++17 -o Unified_cpp_mozglue_baseprofiler0.o -c  -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/stl_wrappers -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/system_wrappers -include /NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DIMPL_MFBT -DMOZ_VTUNE_INSTRUMENTATION -DIMPL_MFBT -DMOZ_HAS_MOZGLUE -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/baseprofiler -I/NEW-SSD/moz-obj-dir/objdir-tb3/mozglue/baseprofiler -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/baseprofiler/core -I/NEW-SSD/NREF-COMM-CENTRAL/mozilla/mozglue/linker -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nspr -I/NEW-SSD/moz-obj-dir/objdir-tb3/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /NEW-SSD/moz-obj-dir/objdir-tb3/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++2a-compat -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -Wno-psabi -fno-sized-deallocation -fno-aligned-new -fno-builtin-strlen -Wl,--gdb-index -Dfdatasync=fdatasync -DDEBUG_4GB_CHECK -DUSEHELGRIND=1 -DUSEVALGRIND=1 -DDEBUG -g -gsplit-dwarf -Werror=sign-compare -Werror=unused-result -Werror=unused-variable -Werror=format -fuse-ld=gold -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -g -Og -fvar-tracking -gdwarf-4 -fvar-tracking-assignments -freorder-blocks -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow -Wno-ignored-qualifiers  -MD -MP -MF .deps/Unified_cpp_mozglue_baseprofiler0.o.pp  -fdiagnostics-color  Unified_cpp_mozglue_baseprofiler0.cpp
In file included from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap.h:47,
                 from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/ldap-int.h:87,
                 from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:39:
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c: In function ‘ldap_utf8strtok_r’:
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:816:71: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  816 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc((const char**)&s) : *s++)
      |                                                                       ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:185:8: note: in expansion of macro ‘LDAP_UTF8GETC’
  185 |   sc = LDAP_UTF8GETC(sp);
      |        ^~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:814:57: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  814 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc(&s) : *s++)
      |                                                         ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:186:24: note: in expansion of macro ‘LDAP_UTF8GETCC’
  186 |   for (bp = brk; (bc = LDAP_UTF8GETCC(bp)) != 0;) {
      |                        ^~~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:816:71: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  816 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc((const char**)&s) : *s++)
      |                                                                       ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:200:10: note: in expansion of macro ‘LDAP_UTF8GETC’
  200 |     sc = LDAP_UTF8GETC(sp);
      |          ^~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/include/ldap-extension.h:814:57: error: operand of ‘?:’ changes signedness from ‘char’ to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
  814 |   ((0x80 & *(unsigned char*)(s)) ? ldap_utf8getcc(&s) : *s++)
      |                                                         ^~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/ldap/c-sdk/libraries/libldap/utf8.c:203:17: note: in expansion of macro ‘LDAP_UTF8GETCC’
  203 |       if ((bc = LDAP_UTF8GETCC(bp)) == sc) {
      |                 ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
gmake[4]: *** [/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/rules.mk:597: utf8.o] Error 1
gmake[4]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/ldap/c-sdk/libraries/libldap'
gmake[3]: *** [/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/recurse.mk:72: comm/ldap/c-sdk/libraries/libldap/target-objects] Error 2
gmake[3]: *** Waiting for unfinished jobs....

```

Back to Bug 1243121 Comment 56