Bugzilla

Review of attachment 8918402 [details] [diff] [review]:
-----------------------------------------------------------------

Move extensions/MetricsGraphics/ to static/metricsgraphics/, there is no reason to keep this under extensions.

To make sure the (new) static directory is accessible, incorporate this patch:

diff --git a/Bugzilla/Install/Filesystem.pm b/Bugzilla/Install/Filesystem.pm
index 2a2e9b71a..a3191be33 100644
--- a/Bugzilla/Install/Filesystem.pm
+++ b/Bugzilla/Install/Filesystem.pm
@@ -302,6 +302,8 @@ sub FILESYSTEM {
                                      dirs => DIR_WS_SERVE },
          js                    => { files => WS_SERVE,
                                      dirs => DIR_WS_SERVE },
+         static                => { files => WS_SERVE,
+                                    dirs  => DIR_WS_SERVE },
          $skinsdir             => { files => WS_SERVE,
                                      dirs => DIR_WS_SERVE },
          'docs/*/html'         => { files => WS_SERVE,

::: extensions/BMO/template/en/default/hook/bug_modal/edit-custom_field-cf_crash_signature.html.tmpl
@@ +25,5 @@
>              [@ [% sig FILTER html %] ]
>            </a>
>            [%
> +          IF querystring == "";
> +            querystring = "$sig";

No need to do "$sig" here, can just write sig

@@ +27,5 @@
>            [%
> +          IF querystring == "";
> +            querystring = "$sig";
> +          ELSE;
> +            querystring = "$querystring\\\$sig";

I think this is a mistake -- one extra \ means it becomes literally '$sig'