Bug 1348064 Comment 23 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I have a question related to ``GenericConversationPrototype``. 
In this patch, I am adding functionality that if you close any conversation, we will also leave that room. 
```
close() {
    this._account._client.leave(this._roomId);
    this._account._roomList.delete(this._roomId);
    GenericConvChatPrototype.close.call(this);
 },
```
But when we remove the account, we just need to remove all the conversations. At that time, we don't want to leave the group/direct messaging. At that time, we need GenericConversationPrototype. So I think GenericConversationPrototype is needed.
Revision 1 by
on 
I have a question related to ``GenericConversationPrototype``. 
In this patch, I am adding functionality that if you close any conversation, we will also leave that room. 
```
close() {
    this._account._client.leave(this._roomId);
    this._account._roomList.delete(this._roomId);
    GenericConvChatPrototype.close.call(this);
 },
```
But when we remove the account, we just need to remove all the conversations. At that time, we don't want to leave the group/direct messaging. At that time, we need GenericConversationPrototype. So I think ``GenericConversationPrototype`` is needed.

Back to Bug 1348064 Comment 23