Bugzilla

There is a call to dispatch the list of search engines when this checkbox is clicked, as follows:

        } else if (PREFS_SEARCH_SUGGESTIONS_ENABLED.equals(prefName)) {
            // Tell Gecko to transmit the current search engine data again, so
            // BrowserSearch is notified immediately about the new enabled state.
            EventDispatcher.getInstance().dispatch("SearchEngines:GetVisible", null);
        }

This is causing the ListView to reload in the object hierarchy. I commented out the EventDispatcher so that it does dispatch the message and the flickering goes away and the search bar works the same as if I left this in there. Given that the preferences are being update and the BrowserSearch reads the preferences is this dispatch absolutely necessary. Comment indicates that the dispatch is needed to update the BrowserSearch but works even without it. 

Is this dispatch absolutely necessary?

There is a call to dispatch the list of search engines when this checkbox is clicked, as follows:

        } else if (PREFS_SEARCH_SUGGESTIONS_ENABLED.equals(prefName)) {
            // Tell Gecko to transmit the current search engine data again, so
            // BrowserSearch is notified immediately about the new enabled state.
            EventDispatcher.getInstance().dispatch("SearchEngines:GetVisible", null);
        }

This is causing the ListView to reload in the object hierarchy. I commented out the EventDispatcher so that it does dispatch the message and the flickering goes away and the search bar works the same as if I left this in there. Given that the preferences are being update and the BrowserSearch reads the preferences is this dispatch absolutely necessary. Comment indicates that the dispatch is needed to update the BrowserSearch but works even without it. 

Is this dispatch absolutely necessary?

I will generate a test apk and submit to the testing group to see if there is any effects not handled by removing this else if group and it's contents.

There is a call to dispatch the list of search engines when this checkbox is clicked, as follows:

        } else if (PREFS_SEARCH_SUGGESTIONS_ENABLED.equals(prefName)) {
            // Tell Gecko to transmit the current search engine data again, so
            // BrowserSearch is notified immediately about the new enabled state.
            EventDispatcher.getInstance().dispatch("SearchEngines:GetVisible", null);
        }

This is causing the ListView to reload in the object hierarchy. I commented out the EventDispatcher so that it does dispatch the message and the flickering goes away and the search bar works the same as if I left this in there. Given that the preferences are being update and the BrowserSearch reads the preferences is this dispatch absolutely necessary? Comment indicates that the dispatch is needed to update the BrowserSearch but works even without it. 

Is this dispatch absolutely necessary?

I will generate a test apk and submit to the testing group to see if there is any effects not handled by removing this else if group and it's contents.