Bugzilla

Marco, bug 1626946 actually does a good job of recalling historical suggestions. Comment 11 here has my initial thoughts about that, so please read that first.

I think we should rely 100% on historical search suggestions bubbling up through the usual frecency mechanism from Places history, and we shouldn't rely on form history at all. Therefore I propose that we remove the `maxHistoricalSearchSuggestions` pref and hardcode that value to zero.

If you agree with that, then we can close this bug or mark it as a dupe of bug 1626946 (but see below). I'll file a new bug for removing `maxHistoricalSearchSuggestions`. And there may also be follow-up bugs to bug 1626946 -- I'm thinking specifically of using a different favicon for historical suggestions, which we can ask Verdi about.

However, comment 0 here also talks about the ability to easily edit your search terms. So I suggest we leave this open but make it specifically about that, and not about restyling searches.

What do you think?

Marco, bug 1626946 actually does a good job of recalling historical suggestions. Comment 11 here has my initial thoughts about that, so please read that first.

I think we should rely 100% on historical search suggestions bubbling up through the usual frecency mechanism from Places history, and we shouldn't rely on form history at all. Therefore I propose that we remove the `maxHistoricalSearchSuggestions` pref and hardcode that value to zero.

If you agree with that, then we can close this bug or mark it as a dupe of bug 1626946 (but see below). I'll file a new bug for removing `maxHistoricalSearchSuggestions`. And there may also be follow-up bugs to bug 1626946 -- I'm thinking specifically of using a different favicon for historical suggestions, which we can ask Verdi about.

However, comment 0 here also talks about the ability to easily edit your search terms. So I suggest we leave this open but make it specifically about that, and not about restyling searches or historical searches.

What do you think?

Marco, bug 1626946 actually does a good job of recalling historical searches. Comment 11 here has my initial thoughts about that, so please read that first.

I think we should rely 100% on historical searches bubbling up through the usual frecency mechanism from Places history, and we shouldn't rely on form history at all. Therefore I propose that we remove the `maxHistoricalSearchSuggestions` pref and hardcode that value to zero.

If you agree with that, then we can close this bug or mark it as a dupe of bug 1626946 (but see below). I'll file a new bug for removing `maxHistoricalSearchSuggestions`. And there may also be follow-up bugs to bug 1626946 -- I'm thinking specifically of using a different favicon for historical searches, which we can ask Verdi about.

However, comment 0 here also talks about the ability to easily edit your search terms. So I suggest we leave this open but make it specifically about that, and not about restyling searches or historical searches.

What do you think?