Bugzilla

(In reply to Drew Willcoxon :adw from comment #18)
> `SearchSuggestionController` fetches remote suggestions and form history at the same time and then combines them, so if we want this to be true, we'll need to modify it to wait until form history is fetched before fetching remote suggestions.

I don't think it's a strict requirement but it was one of the things that came out during the discussion and everyone liked the idea. I suppose it could be evaluated if it creates troubles.

(In reply to Drew Willcoxon :adw from comment #19)
> I'm running into some flickering when I enable deduping. I think it's due to the fact that for the first time we now have a provider whose results affect results from other providers. Specifically, the search suggestion provider can cause the muxer to remove history results from the UnifiedComplete provider. That causes flickering because we show results as soon as they're added by their providers.

Could we instead mark them as "stale" so they are just removed later?

(In reply to Drew Willcoxon :adw from comment #20)
> Or, we could stop adding results to the view as soon as they're available. That would let the muxer have more time to dedupe and sort results. But we'd need to have a timeout to make sure the view isn't starved, so that may just postpone the problem, depending on the timeout we choose.

Long term I think we should have a chunked behavior with 16ms timers

(In reply to Drew Willcoxon :adw from comment #18)
> `SearchSuggestionController` fetches remote suggestions and form history at the same time and then combines them, so if we want this to be true, we'll need to modify it to wait until form history is fetched before fetching remote suggestions.

I don't think it's a strict requirement but it was one of the things that came out during the discussion and everyone liked the idea. I suppose it could be evaluated if it creates troubles.

(In reply to Drew Willcoxon :adw from comment #19)
> I'm running into some flickering when I enable deduping. I think it's due to the fact that for the first time we now have a provider whose results affect results from other providers. Specifically, the search suggestion provider can cause the muxer to remove history results from the UnifiedComplete provider. That causes flickering because we show results as soon as they're added by their providers.

Could we instead mark them as "stale" so they are just removed later?
Though, this require coordination with the view that may not be trivial...

(In reply to Drew Willcoxon :adw from comment #20)
> Or, we could stop adding results to the view as soon as they're available. That would let the muxer have more time to dedupe and sort results. But we'd need to have a timeout to make sure the view isn't starved, so that may just postpone the problem, depending on the timeout we choose.

Long term I think we should have a chunked behavior with 16ms timers