Okay - I addressed your comments and re-requested review because I needed to deal with some test failures. 1) I needed to change the _isDimensionRounded check to specifically check that we rounded to the intended dimension. 2) I needed to handle a really weird resize situation I explain in a comment in Patch 4. I didn't solve this at the root; but I found a way to detect when it occured and work around it in the test. 3) I needed to correct a different test that never reset the zoom level 4) It turns out that using border looks correct but messes with event delivery (it's offset by the border) so I need to use margin like Tim did originally. 5) I added a bunch of logging that I used to debug the test that I think would be useful in the future. I never observed any of these issues when using the pref during browsing. A diff of the Patch 3 you reviewed to the current Patch 3 is here: https://www.diffchecker.com/CcVKKNIP A diff of the Patch 4 you reviewed to the current Patch 4 is here: https://www.diffchecker.com/aVqay8tL
Bug 1407366 Comment 45 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Okay - I addressed your comments and re-requested review because I needed to deal with some test failures. 1) I needed to change the _isDimensionRounded check to specifically check that we rounded to the intended dimension. 2) I needed to handle a really weird resize situation I explain in a comment in Patch 4. I didn't solve this at the root; but I found a way to detect when it occured and work around it in the test. 3) I needed to correct a different test that never reset the zoom level 4) It turns out that using border looks correct but messes with event delivery (it's offset by the border) so I need to use margin like Tim did originally. 5) I added a bunch of logging that I used to debug the test that I think would be useful in the future. I never observed any of these issues when using the pref during browsing. A diff of the Patch 3 you reviewed to the current Patch 3 is here: https://www.diffchecker.com/CcVKKNIP A diff of the Patch 4 you reviewed to the current Patch 4 is here: https://www.diffchecker.com/aVqay8tL Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff9f10ddcbe7ef0f8a001b0f447c137e99f267ef