Bug 1423714 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

### Beta/Release Uplift Approval Request
* **User impact if declined**: Users who want to switch to Firefox but have their logins saved in Chrome on macOS would be less likely to use Firefox as their primary browser.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: https://jira.mozilla.com/browse/PI-293

* Test that login import from Chrome on Windows still works
* Test that login import from Chrome on macOS works (including with non-ASCII usernames and passwords)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: Worst case it causes a crash when a user chooses to import logins from Chrome on macOS but it shouldn't impact subsequent Firefox sessions. We could easily disable the migrator if this happened (not via a pref at the moment but it could be done via Normandy by unregistering the XPCOM component).

A reason why I'm suggesting uplift is because I think it will be valuable for the marketing around Fx70 with all the login improvements in it and because importing from other browsers isn't something that gets much testing in pre-release anyways so this is a good candidate for skipping ahead on the trains once QA has tested it.
* **String changes made/needed**: None
### Beta/Release Uplift Approval Request
* **User impact if declined**: Users who want to switch to Firefox but have their logins saved in Chrome on macOS would be less likely to use Firefox as their primary browser.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: https://jira.mozilla.com/browse/PI-293

* Test that login import from Chrome on Windows still works
* Test that login import from Chrome on macOS works (including with non-ASCII usernames and passwords)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: Worst case it causes a crash when a user chooses to import logins from Chrome on macOS but it shouldn't impact subsequent Firefox sessions. We could add a pref to disable this but we don't currently have one.

A reason why I'm suggesting uplift is because I think it will be valuable for the marketing around Fx70 with all the login improvements in it and because importing from other browsers isn't something that gets much testing in pre-release anyways so this is a good candidate for skipping ahead on the trains once QA has tested it.
* **String changes made/needed**: None

Back to Bug 1423714 Comment 8