Monday update, had written a long post and was about to attach a progress patch.... but during the post i realized a few things, and made a few additions... I think we are close... The idea with having these 'nsresult GetIntImpl (uint32_t' instead of 'nsresult GetIntImpl (IntID' with its own Switch statement, was that these values will be between 0 and 2, and those are already occupied by https://searchfox.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#518-527 (so for now i have those lines commented away, so i can build it :)) So now if i set the value of the button i want in this for loop for each button, https://searchfox.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#1200-1210 --- switch (buttonLayout[i]) { case MOZ_GTK_HEADER_BAR_BUTTON_MINIMIZE: mCSDMinimizeButton = true; mCSDMinimizeButtonPosition = 2; break; case MOZ_GTK_HEADER_BAR_BUTTON_MAXIMIZE: mCSDMaximizeButton = true; mCSDMaximizeButtonPosition = 1; break; case MOZ_GTK_HEADER_BAR_BUTTON_CLOSE: mCSDCloseButton = true; mCSDCloseButtonPosition = 0; break; --- it will position them in the order i want them. i had mCSDMinimizeButtonPosition = i earlier. That would mean that the order of the buttons in the buttonlayout array is not in the right order, right? even though i think we debunked that a long time ago.... anyway , some progress in the right direction... i think :)
Bug 1432090 Comment 32 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Monday update, had written a long post and was about to attach a progress patch.... but during the post i realized a few things, and made a few additions... I think we are close... The idea with having these 'nsresult GetIntImpl (uint32_t' instead of 'nsresult GetIntImpl (IntID' with its own Switch statement, was that these values will be between 0 and 2, and those are already occupied by https://searchfox.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#518-527 (so for now i have those lines commented away, so i can build it :)) So now if i set the value of the button i want in this for loop for each button, https://searchfox.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#1200-1210 --- switch (buttonLayout[i]) { case MOZ_GTK_HEADER_BAR_BUTTON_MINIMIZE: mCSDMinimizeButton = true; mCSDMinimizeButtonPosition = 2; break; case MOZ_GTK_HEADER_BAR_BUTTON_MAXIMIZE: mCSDMaximizeButton = true; mCSDMaximizeButtonPosition = 1; break; case MOZ_GTK_HEADER_BAR_BUTTON_CLOSE: mCSDCloseButton = true; mCSDCloseButtonPosition = 0; break; --- it will position them in the order i want them. i had mCSDMinimizeButtonPosition = i earlier. That would mean that the order of the buttons in the buttonlayout array is not in the right order, right? even though i think we debunked that a long time ago.... anyway , some progress in the right direction... i think :)