Bug 1432856 Comment 31 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Thanks for verifying the fix!

(In reply to Bodea Daniel [:danibodea] from comment #30)
> Hsin-Tsai, I am requesting information from you in hope that you could answer some questions regarding the fix. Which are:
>  One issue that I observed is that the browser will instantly leave the full-screen mode when the pop-up is focused, but I am assuming that this is the compromise we are making in favor of not covering the notification about exiting full-screen. Can you confirm this is a valid approach?

Yes, this is the approach we opted for. See discussion above.

>  A second issue is that the pop-up that gets focused will lose its focus because the "normal" browser window will be focused when leaving full-screen mode. This issue occurs only on Windows and Mac OS. Is this a valid issue? Should it be logged?

Yes, that's a bit inconsistent. The behavior on Linux is the correct one, we should honor the focus request, so the window should be in focus after leaving fullscreen. I'll file a follow up bug.
Thanks for verifying the fix!

(In reply to Bodea Daniel [:danibodea] from comment #30)
> Hsin-Tsai, I am requesting information from you in hope that you could answer some questions regarding the fix. Which are:
>  One issue that I observed is that the browser will instantly leave the full-screen mode when the pop-up is focused, but I am assuming that this is the compromise we are making in favor of not covering the notification about exiting full-screen. Can you confirm this is a valid approach?

Yes, this is the approach we opted for. See discussion above.

>  A second issue is that the pop-up that gets focused will lose its focus because the "normal" browser window will be focused when leaving full-screen mode. This issue occurs only on Windows and Mac OS. Is this a valid issue? Should it be logged?

Yes, that's a bit inconsistent. The behavior on Linux is the correct one, we should honor the focus request, so the window should be in focus after leaving fullscreen. I've filed Bug 1613065.

Back to Bug 1432856 Comment 31