Bug 1450652 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Other than bug 1512993, do we know what we are going to do with `display="xul:button"`?

I looked at it a bit and it looks like we only map `<xul:button>` tag to `XULButtonBoxFrame`. There were no signs of references to `<xul:toolbarbutton>` that would map to it to the frame.

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/layout/base/nsCSSFrameConstructor.cpp#3960

- For the button binding, does the `display="xul:button"` value is actually redundant?
- For the toolbarbutton binding, does a simple copy-paste fix of the line above makes the `display="xul:button"` redundant?
Revision 1 by
on 
Other than bug 1512993, do we know what we are going to do with `display="xul:button"`?

I looked at it a bit and it looks like we only map `<xul:button>` tag to `XULButtonBoxFrame`. There were no signs of references to `<xul:toolbarbutton>` that would map the tag to the frame.

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/layout/base/nsCSSFrameConstructor.cpp#3960

- For the button binding, does the `display="xul:button"` value is actually redundant?
- For the toolbarbutton binding, does a simple copy-paste fix of the line above makes the `display="xul:button"` redundant?

Back to Bug 1450652 Comment 12