Bug 1485016 Comment 58 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

## Beta/Release Uplift Approval Request

### Feature/Bug causing the regression

None

### User impact if declined

We'd like to land this small security improvement in 66

### Is this code covered by automated tests?

Yes

### Has the fix been verified in Nightly?

Yes

### Needs manual test from QE?

No

### If yes, steps to reproduce



### List of other uplifts needed

Bug 1485016

### Risk to taking this patch

High

### Why is the change risky/not risky? (and alternatives if risky)

We're enabling a Windows compiler mitigation that has the potential for unexpected behavior. We would need to observe crashes on Beta and see if we detect anything unusual; and back it out if so.

### String changes made/needed
## Beta/Release Uplift Approval Request

### Feature/Bug causing the regression

None

### User impact if declined

We'd like to land this small security improvement in 66

### Is this code covered by automated tests?

Yes

### Has the fix been verified in Nightly?

Yes

### Needs manual test from QE?

No

### If yes, steps to reproduce



### List of other uplifts needed

Bug 1485016 (before this one), Bug 1485016 (after this one)

### Risk to taking this patch

High

### Why is the change risky/not risky? (and alternatives if risky)

We're enabling a Windows compiler mitigation that has the potential for unexpected behavior. We would need to observe crashes on Beta and see if we detect anything unusual; and back it out if so.

### String changes made/needed

Back to Bug 1485016 Comment 58