Bug 1490026 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Skaiste from comment #3)
> I got it running locally on my machine. Found out that you don’t need to press tab button three times to trigger the bug after pressing enter. One time pressing tab and then enter also triggers the bug same way. 

True! We just finished rewriting the translation page and the errors is now reproducible slightly differently. Sorry for not updating that in the bug before.

We'll need to disable the "Enter" keyboard shortcut for logged in users and read-only projects, same as we do for the editor menu:
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/fluenteditor/components/Editor.js#L176

> I tried changing some simple things in the website to check if it’s all working together, but it doesn’t. For example I tried to change first paragraph  in InteractiveTour.js file and make it different, but it stayed the same. I have the server running with `make run` is there is anything else I would need to do?

To change localizable strings you'll actually have to change them in `the public/static/locale/en-US/translate.ftl` and run `make build` (which will take time). So to quickly test that you are actually making changes, you can trying removing the entire `Localized#interactivetour-InteractiveTour--intro-title` block instead.
(In reply to Skaiste from comment #3)
> I got it running locally on my machine. Found out that you don’t need to press tab button three times to trigger the bug after pressing enter. One time pressing tab and then enter also triggers the bug same way. 

True! We just finished rewriting the translation page and the error is now reproducible slightly differently. Sorry for not updating that in the bug before.

We'll need to disable the "Enter" keyboard shortcut for logged in users and read-only projects, same as we do for the editor menu:
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/fluenteditor/components/Editor.js#L176

> I tried changing some simple things in the website to check if it’s all working together, but it doesn’t. For example I tried to change first paragraph  in InteractiveTour.js file and make it different, but it stayed the same. I have the server running with `make run` is there is anything else I would need to do?

To change localizable strings you'll actually have to change them in `the public/static/locale/en-US/translate.ftl` and run `make build` (which will take time). So to quickly test that you are actually making changes, you can trying removing the entire `Localized#interactivetour-InteractiveTour--intro-title` block instead.

Back to Bug 1490026 Comment 4