Bug 1493158 Comment 43 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Here's a proof of concept / WIP patch which realizes my proposal of comment 33 ff, much like in the screenshots 1-3 of attachment 9041093 [details] ff.

Please ignore bug 1525828 of duplicate type selector (menulist), which is not caused by my patch.

Otherwise this works very well for me.
:focus-within works perfectly to mimic not-yet existing parent or previous sibling selector, pure CSS without any javascript workarounds.
(One would wish for :hover-within which would allow us to style the entire recipient row somehow when the delete button is hovered...)

1) delete button and type selector dropdown styling only shown when recipient or any part of the recipient row is hovered or has focus.
2) Otherwise both hidden which does a great job to declutter the entire recipient area from dozens of useless type selector dropdowns.
3) aw-menulist has finally returned to a "normal" dropdown styling with white background: feels much lighter, less awkward, consistent with the "From" dropdown, and more like an actual editable windows-style dropdown. Editable? Yes, you can actually type "BCC" when the dropdown has focus and it'll work if your typing speed is fast enough.

WIP:
- No guarantees for selectors to be in the right file or in the right sections - essentially I tried to make it work for Windows 10 but there seem to be dozens of scattered files, sections and rules which define this. Richard will be able to look into the details...
- Linux / OSX styles not yet included.
Here's a proof of concept / WIP patch which realizes my proposal of comment 33 ff, much like in the screenshots 1-3 of attachment 9041093 [details] ff.

Please ignore bug 1525828 of duplicate type selector (menulist), which is not caused by my patch.

Otherwise this works very well for me.
:focus-within works perfectly to mimic not-yet existing parent or previous sibling selector, pure CSS without any javascript workarounds.
(One would wish for :hover-within which would allow us to style the entire recipient row somehow when the delete button is hovered...)

1) delete button and type selector dropdown styling only shown when recipient or any part of the recipient row is hovered or has focus.
2) Otherwise both hidden which does a great job to declutter the entire recipient area from dozens of useless type selector dropdowns.
3) aw-menulist has finally returned to a "normal" dropdown styling with white background: feels much lighter, less awkward, consistent with the "From" dropdown, and more like an actual editable windows-style dropdown. Editable? Yes, you can actually type "BCC" when the dropdown has focus and it'll work if your typing speed is fast enough.

WIP:
- No guarantees for selectors to be in the right file or in the right sections - essentially I tried to make it work for Windows 10 but there seem to be dozens of scattered files, sections and rules which define this. Richard will be able to look into the details...
- Linux / OSX styles not yet included.

If Paenglab agrees, I'd like to take this bug if my proposal is accepted, assuming that we'll be done here with few iterations. Btw, does HG accept two patch authors for one patch?
Here's a proof of concept / WIP patch which realizes my proposal of comment 33 ff, much like in the screenshots 1-3 of attachment 9041093 [details] ff.

Please ignore bug 1525828 of duplicate type selector (menulist), which is not caused by my patch.

Otherwise this works very well for me.
:focus-within works perfectly to mimic not-yet existing parent or previous sibling selector, pure CSS without any javascript workarounds.
(One would wish for :hover-within which would allow us to style the entire recipient row somehow when the delete button is hovered...)

1) delete button and type selector dropdown styling only shown when recipient or any part of the recipient row is hovered or has focus.
2) Otherwise both hidden which does a great job to declutter the entire recipient area from dozens of useless type selector dropdowns.
3) aw-menulist has finally returned to a "normal" dropdown styling with white background: feels much lighter, less awkward, consistent with the "From" dropdown, and more like an actual editable windows-style dropdown. Editable? Yes, you can actually type "BCC" when the dropdown has focus and it'll work if your typing speed is fast enough.

WIP:
- No guarantees for selectors to be in the right file or in the right sections - essentially I tried to make it work for Windows 10 but there seem to be dozens of scattered files, sections and rules which define this. Richard will be able to look into the details...
- Linux / OSX styles not yet included.
- Richard, could you make the recipient type selector to have same height as recipient input, so that the border boxes will match, which looks neater.

If Paenglab agrees, I'd like to take this bug if my proposal is accepted, assuming that we'll be done here with few iterations. Btw, does HG accept two patch authors for one patch?

Back to Bug 1493158 Comment 43