Tested with a) "Don't keep activities" enabled. In that case opening Fennec, going into Settings and back again correctly restores GeckoApp with a savedInstanceState present. b) "Don't keep activities" disabled. Open Fennec, open a custom tab, then swipe Fennec itself away. If your OEM didn't do any customisation in this area, this should keep the app process itself running - verify by switching to the custom tab and noting that it immediately appears and *doesn't* reload. Then relaunch Fennec - the contents of the current tab should reappear 1.) at all and 2.) without any signs of reloading. The context menu should work. My patch fixes b), while also not breaking a).
Bug 1494748 Comment 83 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Tested with a) "Don't keep activities" enabled. In that case opening Fennec, going into our Settings and back again correctly restores GeckoApp with a savedInstanceState present. b) "Don't keep activities" disabled. Open Fennec, open a custom tab, then swipe Fennec itself away. If your OEM didn't do any customisation in this area, this should keep the app process itself running - verify by switching to the custom tab and noting that it immediately appears and *doesn't* reload. Then relaunch Fennec - the contents of the current tab should reappear 1.) at all and 2.) without any signs of reloading. The context menu should work. My patch fixes b), while also not breaking a).
Tested with a) "Don't keep activities" enabled. In that case opening Fennec, going into our Settings and back again correctly restores GeckoApp with a savedInstanceState present. b) "Don't keep activities" disabled. Open Fennec, open a custom tab, then swipe Fennec itself away. If your OEM didn't do any customisation in this area, this should keep the app process itself running - verify by switching to the custom tab and noting that it immediately appears and *doesn't* reload. Then relaunch Fennec - the contents of the current tab should reappear 1.) at all and 2.) without any signs of reloading. The context menu should work. c) Swipe away any activities belonging to Fennec, then launch it again. Put it into the background and execute `adb shell am kill <package name>` to simulate an OOM-kill. Now launch it again. Everything should still work normally with a savedInstanceState present, but the process having been killed in the mean time. My patch fixes b), while also not breaking a) or c).
Tested with a) "Don't keep activities" enabled. In that case opening Fennec, going into our Settings and back again correctly restores GeckoApp with a savedInstanceState present. b) "Don't keep activities" disabled. Open Fennec, open a custom tab, then swipe Fennec itself away. If your OEM didn't do any customisation in this area, this should keep the app process itself running - verify by switching to the custom tab and noting that it immediately appears and *doesn't* reload. Then relaunch Fennec - the contents of the current tab should reappear 1.) at all and 2.) without any signs of reloading. The context menu should work. c) Swipe away any activities belonging to Fennec, then launch it again. Put it into the background and execute `adb shell am kill <package name>` to simulate an OOM-kill. Now launch it again. Everything should still work normally with a savedInstanceState present, but the process having been killed in the meantime. My patch fixes b), while also not breaking a) or c).
Tested with a) "Don't keep activities" enabled. In that case opening Fennec, going into our Settings and back again correctly restores GeckoApp with a savedInstanceState present. b) "Don't keep activities" disabled. Open Fennec, open a custom tab, then swipe Fennec itself away. If your OEM didn't do any customisation in this area, this should keep the app process itself running - verify by switching to the custom tab and noting that it immediately appears and *doesn't* reload. Then relaunch Fennec - the contents of the current tab should reappear 1.) at all and 2.) without any signs of reloading. The context menu should work. c) Swipe away any activities belonging to Fennec, then launch it again. Put it into the background and execute `adb shell am kill <package name>` to simulate an OOM-kill (Edit: Not sure how that might behave if the app actually has a service running, e.g. Nightly the Stumbler service. With a local build, which doesn't run the stumbler by default, it does work to simulate OOM-kills, though). Now launch it again. Everything should still work normally with a savedInstanceState present, but the process having been killed in the meantime. My patch fixes b), while also not breaking a) or c).