Bug 1509168 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #3)

> I don't quite understand the commit message...  js::GetArrayBufferViewLengthAndData is friend API just like JS_GetObjectAsArrayBufferView. 

Sorry, I'm new to the JS codebase, after re-reading the js/src/jsfriendapi.h declarations, I found js::GetArrayBufferViewLengthAndData a JS_FRIEND_API. I will update the commit message.


> The real change is that JS_GetObjectAsArrayBufferView can handle a CCW for an ArrayBufferView while js::GetArrayBufferViewLengthAndData can't, right?

Yes, this is what I meant.
Revision 1 by
on 
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #3)

> I don't quite understand the commit message...  js::GetArrayBufferViewLengthAndData is friend API just like JS_GetObjectAsArrayBufferView. 

Sorry, I'm new to the JS codebase, after re-reading the js/src/jsfriendapi.h declarations, I found js::GetArrayBufferViewLengthAndData is indeed a JS_FRIEND_API. I will update the commit message.


> The real change is that JS_GetObjectAsArrayBufferView can handle a CCW for an ArrayBufferView while js::GetArrayBufferViewLengthAndData can't, right?

Yes, this is what I meant.

Back to Bug 1509168 Comment 4