(In reply to Nick Alexander :nalexander [he/him] from comment #4) > > > Probably |mach lint| and other static analysis tools already set patterns for this, since we do some native code analysis that requires the clang plugin already (AFAIK). (That didn't exist when I made these all build jobs, way back when.) > > > > Not that I can see. All lints in //tools/lint are very simple static checks > > that don't require any build stuff (maybe I'm missing something?) I'll look > > into this more. > > Oh. That's unfortunate. We'll have to dig more into this. Just noticed that `./mach static-analysis check <file>` does more or less what our lint does, so it should be possible to do this!
Bug 1512487 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Nick Alexander :nalexander [he/him] from comment #4) > > > Probably |mach lint| and other static analysis tools already set patterns for this, since we do some native code analysis that requires the clang plugin already (AFAIK). (That didn't exist when I made these all build jobs, way back when.) > > > > Not that I can see. All lints in //tools/lint are very simple static checks > > that don't require any build stuff (maybe I'm missing something?) I'll look > > into this more. > > Oh. That's unfortunate. We'll have to dig more into this. Just noticed that `./mach static-analysis check <file>` does more or less what our lint does and it's integrated with phabricator, so it should be possible to do this!