Bug 1514936 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Jorg K (GMT+1) from comment #8)
> Thanks, I'll keep an eye on it. de-RDF is actually progressing, just not
> fast enough. Since moving the RDF service to C-C we had a bit of bustage in
> it :-(

Might want to add a `MOZ_RELEASE_ASSERT(!aOuter);` here and do a try run with it. If it doesn't trip, you can just remove all of the aggregation stuff from that class. If it does, you're going to need fix those callers to call the InMemoryDataSource constructor directly. And if you want to continue using the aggregation macros, you'll need to move nsAgg.h into comm-central.
Revision 1 by
on 
(In reply to Jorg K (GMT+1) from comment #8)
> Thanks, I'll keep an eye on it. de-RDF is actually progressing, just not
> fast enough. Since moving the RDF service to C-C we had a bit of bustage in
> it :-(

Might want to add a `MOZ_RELEASE_ASSERT(!aOuter);` here[1] and do a try run with it. If it doesn't trip, you can just remove all of the aggregation stuff from that class. If it does, you're going to need fix those callers to call the InMemoryDataSource constructor directly. And if you want to continue using the aggregation macros, you'll need to move nsAgg.h into comm-central.

[1]: https://searchfox.org/comm-central/rev/5a7cb6346ed51a400bc6910465b0cdf9c90af5f9/rdf/base/nsInMemoryDataSource.cpp#719

Back to Bug 1514936 Comment 9