Bug 1515712 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Robert Helmer [:rhelmer] from comment #6)
> > Another note: since you state in Q9 that you're interested in the current prevalence of these errors it seems as though you could start these collections as expiring collections to serve that need and "upgrade" them to eternal collection pending the results of your analysis. Something to consider.
> 
> So in Scalars.yaml I set:
> 
>     expires: "71"
> 
> Is there anything else I need to do to make them expiring collections?

We should probably cut another edition of the data review request that says you only want it until the end Firefox 70 for now, and I'll reply with a marginally-different data review response. This'll help future us understand what the final result was.

But yeah, as far as code goes, that's it.

When Nightly hits 70 you should (the service that does this is somewhat reliable) get an email about it expiring. And shortly thereafter a bug might be filed when the version increase simulation builds start running if you have an automated test that doesn't account for the possibility of your collection being expired. (collecting to an expired metric is a no-op. No errors, but snapshots won't have the accumulations). This'll help us remember to look at the data and make our conclusions, and see if the metric should be removed or renewed.
(In reply to Robert Helmer [:rhelmer] from comment #6)
> > Another note: since you state in Q9 that you're interested in the current prevalence of these errors it seems as though you could start these collections as expiring collections to serve that need and "upgrade" them to eternal collection pending the results of your analysis. Something to consider.
> 
> So in Scalars.yaml I set:
> 
>     expires: "71"
> 
> Is there anything else I need to do to make them expiring collections?

We should probably cut another edition of the data review request that says you only want it until the end Firefox 70 for now, and I'll reply with a marginally-different data review response. This'll help future us understand what the final result was.

But yeah, as far as code goes, that's it.

When Nightly hits 70 you should (the service that does this is somewhat reliable) get an email about it expiring in the next version. And shortly thereafter a bug might be filed when the version increase simulation builds start running if you have an automated test that doesn't account for the possibility of your collection being expired. (collecting to an expired metric is a no-op. No errors, but snapshots won't have the accumulations). This'll help us remember to look at the data and make our conclusions, and see if the metric should be removed or renewed.

Back to Bug 1515712 Comment 7