Bug 1517080 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Re comment 4:

Mats, are you suggesting that we fixed all the call sites that use `nsFrameItems::AddChild()` to just use `nsFrameList::AppendFrames()` so that we can get rid of `nsFrameItems::AddChild` and `nsFrameItems` altogether? 

Does it matter if we lose the the OOF assertion in `nsFrameItems::AddChild()`? I guess maybe that's OK because we still have an assertion in nsIFrame::GetPlaceholderFrame() and nsCSSFrameConstructor::CreatePlaceholderFrameFor() is stable enough.
Revision 1 by
on 
Re comment 4:

Mats, are you suggesting that we fixed all the call sites that use `nsFrameItems::AddChild()` to just use `nsFrameList::AppendFrames()` so that we can get rid of `nsFrameItems::AddChild` and `nsFrameItems` altogether? 

Does it matter if we lose the the OOF assertion in `nsFrameItems::AddChild()`? I guess maybe that's OK because we still have an assertion in `nsIFrame::GetPlaceholderFrame()` and `nsCSSFrameConstructor::CreatePlaceholderFrameFor()` is stable enough.

Back to Bug 1517080 Comment 6