> Tarek, this commit doesn't stop the upstream certsniffing yet, but it it's still setting the protocol, is that right? This commit should be doing nothing compared to before because the alpn negotiation should happen via the upstream cert sniffing and the fact that the alpn fallback returns an empty string like before . > Do we have the protocols recorded for every server? No, this is going to be added with the new recordings by Bebe > I'm wondering if this caused the big spikes on loadtime across Firefox and Chrome at the end of day, June 3? weird... I guess if June 4th looks high too we need to dig and see what's going on. I don't think anyone else did something in Raptor at that date so that spike could be this commit..
Bug 1517323 Comment 64 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> Tarek, this commit doesn't stop the upstream certsniffing yet, but it it's still setting the protocol, is that right? This commit should be doing nothing compared to before because the alpn negotiation should happen via the upstream cert sniffing and the fact that the alpn fallback returns an empty string like before . > Do we have the protocols recorded for every server? No, this is going to be added with the new recordings by Bebe > I'm wondering if this caused the big spikes on loadtime across Firefox and Chrome at the end of day, June 3? weird... I guess if June 4th looks high too we need to dig and see what's going on. I don't think anyone else did something in Raptor at that date so that spike could be this commit..