Bug 1517710 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

It would have been real nice if it had walked the stack too, but I got it after some fiddling around:
> (gdb) bt
> #0  0x000055f1f7d0690e in mozilla::detail::MutexImpl::lock() ()
> #1  0x00007fed0de1b66c in mozilla::OffTheBooksMutex::Lock() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #2  0x00007fed0fde1b8d in mozilla::SourceMediaStream::SetPullingEnabled(int, bool)::Message::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #3  0x00007fed0fdd130c in mozilla::MediaStreamGraphImpl::RunMessagesInQueue() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #4  0x00007fed0fdd2839 in mozilla::MediaStreamGraphImpl::OneIteration(long) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #5  0x00007fed0fcffce5 in mozilla::ThreadedDriver::RunThread() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #6  0x00007fed0fd0b6f1 in mozilla::MediaStreamGraphInitThreadRunnable::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #7  0x00007fed0de39334 in nsThread::ProcessNextEvent(bool, bool*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #8  0x00007fed0de3b98f in NS_ProcessNextEvent(nsIThread*, bool) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #9  0x00007fed0e32cd3b in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #10 0x00007fed0e2ec36b in MessageLoop::RunInternal() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #11 0x00007fed0e2ec2c6 in MessageLoop::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #12 0x00007fed0de3705e in nsThread::ThreadFunc(void*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
> #13 0x00007fed20534250 in _pt_root () from /home/pehrsons/dev/bug1517710/firefox/libnspr4.so

This is a different failure mode, and bug 1517711, bug 1517844, bug 1517845, bug 1517913, bug 1517960, bug 1517990 are symptoms of this mode, rather than the one I fixed here (AppendMessage()). They're probably heavily related, but let's still take the fix to bug 1517711.

I'll take the fix to bug 1517711.
It would have been real nice if it had walked the stack too, but I got it after some fiddling around:
```(gdb) bt
#0  0x000055f1f7d0690e in mozilla::detail::MutexImpl::lock() ()
#1  0x00007fed0de1b66c in mozilla::OffTheBooksMutex::Lock() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#2  0x00007fed0fde1b8d in mozilla::SourceMediaStream::SetPullingEnabled(int, bool)::Message::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#3  0x00007fed0fdd130c in mozilla::MediaStreamGraphImpl::RunMessagesInQueue() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#4  0x00007fed0fdd2839 in mozilla::MediaStreamGraphImpl::OneIteration(long) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#5  0x00007fed0fcffce5 in mozilla::ThreadedDriver::RunThread() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#6  0x00007fed0fd0b6f1 in mozilla::MediaStreamGraphInitThreadRunnable::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#7  0x00007fed0de39334 in nsThread::ProcessNextEvent(bool, bool*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#8  0x00007fed0de3b98f in NS_ProcessNextEvent(nsIThread*, bool) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#9  0x00007fed0e32cd3b in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#10 0x00007fed0e2ec36b in MessageLoop::RunInternal() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#11 0x00007fed0e2ec2c6 in MessageLoop::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#12 0x00007fed0de3705e in nsThread::ThreadFunc(void*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#13 0x00007fed20534250 in _pt_root () from /home/pehrsons/dev/bug1517710/firefox/libnspr4.so```

This is a different failure mode, and bug 1517711, bug 1517844, bug 1517845, bug 1517913, bug 1517960, bug 1517990 are symptoms of this mode, rather than the one I fixed here (AppendMessage()). They're probably heavily related, but let's still take the fix to bug 1517711.

I'll take the fix to bug 1517711.
It would have been real nice if it had walked the stack too, but I got it after some fiddling around:
```
(gdb) bt
#0  0x000055f1f7d0690e in mozilla::detail::MutexImpl::lock() ()
#1  0x00007fed0de1b66c in mozilla::OffTheBooksMutex::Lock() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#2  0x00007fed0fde1b8d in mozilla::SourceMediaStream::SetPullingEnabled(int, bool)::Message::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#3  0x00007fed0fdd130c in mozilla::MediaStreamGraphImpl::RunMessagesInQueue() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#4  0x00007fed0fdd2839 in mozilla::MediaStreamGraphImpl::OneIteration(long) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#5  0x00007fed0fcffce5 in mozilla::ThreadedDriver::RunThread() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#6  0x00007fed0fd0b6f1 in mozilla::MediaStreamGraphInitThreadRunnable::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#7  0x00007fed0de39334 in nsThread::ProcessNextEvent(bool, bool*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#8  0x00007fed0de3b98f in NS_ProcessNextEvent(nsIThread*, bool) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#9  0x00007fed0e32cd3b in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#10 0x00007fed0e2ec36b in MessageLoop::RunInternal() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#11 0x00007fed0e2ec2c6 in MessageLoop::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#12 0x00007fed0de3705e in nsThread::ThreadFunc(void*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#13 0x00007fed20534250 in _pt_root () from /home/pehrsons/dev/bug1517710/firefox/libnspr4.so
```

This is a different failure mode, and bug 1517711, bug 1517844, bug 1517845, bug 1517913, bug 1517960, bug 1517990 are symptoms of this mode, rather than the one I fixed here (AppendMessage()). They're probably heavily related, but let's still take the fix to bug 1517711.

I'll take the fix to bug 1517711.
It would have been real nice if it had walked the stack too, but I got it after some fiddling around:
```
(gdb) bt
#0  0x000055f1f7d0690e in mozilla::detail::MutexImpl::lock() ()
#1  0x00007fed0de1b66c in mozilla::OffTheBooksMutex::Lock() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#2  0x00007fed0fde1b8d in mozilla::SourceMediaStream::SetPullingEnabled(int, bool)::Message::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#3  0x00007fed0fdd130c in mozilla::MediaStreamGraphImpl::RunMessagesInQueue() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#4  0x00007fed0fdd2839 in mozilla::MediaStreamGraphImpl::OneIteration(long) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#5  0x00007fed0fcffce5 in mozilla::ThreadedDriver::RunThread() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#6  0x00007fed0fd0b6f1 in mozilla::MediaStreamGraphInitThreadRunnable::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#7  0x00007fed0de39334 in nsThread::ProcessNextEvent(bool, bool*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#8  0x00007fed0de3b98f in NS_ProcessNextEvent(nsIThread*, bool) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#9  0x00007fed0e32cd3b in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#10 0x00007fed0e2ec36b in MessageLoop::RunInternal() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#11 0x00007fed0e2ec2c6 in MessageLoop::Run() () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#12 0x00007fed0de3705e in nsThread::ThreadFunc(void*) () from /home/pehrsons/dev/bug1517710/firefox/libxul.so
#13 0x00007fed20534250 in _pt_root () from /home/pehrsons/dev/bug1517710/firefox/libnspr4.so
```

This is a different failure mode, and bug 1517711, bug 1517844, bug 1517845, bug 1517913, and bug 1517990 are symptoms of this mode, rather than the one I fixed here (AppendMessage()). They're probably heavily related, but let's still take the fix to bug 1517711.

I'll take the fix to bug 1517711.

Back to Bug 1517710 Comment 13