Review of attachment 9034772 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thanks! :) It may be useful to have some tests for dynamic changes to the property if you want, though given the previous patch is straight-forward, and that we don't have pre-existing tests for the other properties in WPT, looks like, I don't think I'd feel good enforcing it. ::: testing/web-platform/tests/css/css-lists/counter-reset-increment-set-display-contents.html @@ -4,1 @@ > <link rel="author" title="Rune Lillesveen" href="mailto:futhark@chromium.org"> Maybe we should rename the file to `counter-set-reset-increment-*`? Same for the other existing test. No big deal if not though.
Bug 1518201 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Review of attachment 9034772 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thanks! :) It may be useful to have some tests for dynamic changes to the property if you want, though given the previous patch is straight-forward, and that we don't have pre-existing tests for the other properties in WPT, looks like, I don't think I'd feel good enforcing it. ```patch ::: testing/web-platform/tests/css/css-lists/counter-reset-increment-set-display-contents.html @@ -4,1 @@ > <link rel="author" title="Rune Lillesveen" href="mailto:futhark@chromium.org"> ``` Maybe we should rename the file to `counter-set-reset-increment-*`? Same for the other existing test. No big deal if not though.