Bug 1518753 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Yes, mass change. `grep` finds 45 places where we actually pass an argument to `newGlobal()`; `sed` or `perl` can take care of the rest. I can do it if you like. We just need an option that means "new compartment regardless of --same-compartment".

Looking at the 962 uses of newGlobal in jit-tests, I see there are a handful of old ones that say

```js
var g1 = newGlobal('same-compartment');
```

String arguments are currently ignored; it would be nice to fix these tests to use the existing `sameCompartmentAs: this` option. They would probably just start testing something useful again!
Yes, mass change. `grep` finds 45 places in jit-test/tests/debug where we actually pass an argument to `newGlobal()`; sed or perl can take care of the rest. I can do it if you like. We just need an option that means "new compartment regardless of `--same-compartment`".

I see there are a handful of old ones that say

```js
var g1 = newGlobal('same-compartment');
```

String arguments are currently ignored; it would be nice to fix these tests to use the existing `sameCompartmentAs: this` option. They would probably just start testing something useful again!

Back to Bug 1518753 Comment 5