Bugzilla

(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 9037002 [details]
> Bug 1518895 - Add crash report for VR process.

:gsvelto, I tried to use `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` on Windows with the current m-c. but I got a fail as below, at https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js#262.

 0:16.16 INFO exiting test
 0:16.16 ERROR Unexpected exception NS_ERROR_ABORT:
_abort_failed_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:741:9
do_report_result@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:848:5
Assert<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:54:5
proto.report@resource://testing-common/Assert.jsm:214:5
proto.ok@resource://testing-common/Assert.jsm:234:5
test_main_crash_event_file@c:/Projects/mozilla/gecko_build/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:262:3
async*run_next_test/_run_next_test/<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:22
async*_run_next_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:10
run@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:687:9
_do_main@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:224:3
_execute_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:528:5
@-e:1:1

However, it is good on Mac OS. But, it will get a fail after applying my patch from attachment 9037002 [details]. I think it probably makes sense, because we only enable VR process on Windows. I am wondering if there is any way to skip this VR process crash report test besides Windows?

Moreover, I would like to know how to verify if the crash report works. I was trying to call MOZ_CRASH() at VR process or GPU process and put breakpoints in CrashReporterHost.cpp at the parent process. But I didn't get any events about the report. Even typing about::crashes, I still didn't see any reports. I didn't implement any code in cpp files that are related to the crash report, do I need to add something?

Thanks,

(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 9037002 [details]
> Bug 1518895 - Add crash report for VR process.

:gsvelto, I tried to use `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` on Windows with the current m-c. but I got a fail as below, at https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js#262.

 0:16.16 INFO exiting test
 0:16.16 ERROR Unexpected exception NS_ERROR_ABORT:
_abort_failed_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:741:9
do_report_result@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:848:5
Assert<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:54:5
proto.report@resource://testing-common/Assert.jsm:214:5
proto.ok@resource://testing-common/Assert.jsm:234:5
test_main_crash_event_file@c:/Projects/mozilla/gecko_build/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:262:3
async*run_next_test/_run_next_test/<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:22
async*_run_next_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:10
run@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:687:9
_do_main@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:224:3
_execute_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:528:5
@-e:1:1

However, it is good on Mac OS. Also, I would like to know how to verify if the crash report works. I was trying to call MOZ_CRASH() at VR process or GPU process and put breakpoints in CrashReporterHost.cpp at the parent process. But I didn't get any events about the report. Even typing about::crashes, I still didn't see any reports. I didn't implement any code in cpp files that are related to the crash report, do I need to add something?

Thanks,

(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> Created attachment 9037002 [details]
> Bug 1518895 - Add crash report for VR process.

:gsvelto, I tried to use `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` on Windows with the current m-c. but I got a fail as below, at https://searchfox.org/mozilla-central/rev/c21d6620d384dfb13ede6054015da05a6353b899/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js#262.

 0:16.16 INFO exiting test
 0:16.16 ERROR Unexpected exception NS_ERROR_ABORT:
_abort_failed_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:741:9
do_report_result@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:848:5
Assert<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:54:5
proto.report@resource://testing-common/Assert.jsm:214:5
proto.ok@resource://testing-common/Assert.jsm:234:5
test_main_crash_event_file@c:/Projects/mozilla/gecko_build/_tests/xpcshell/toolkit/components/crashes/tests/xpcshell/test_crash_manager.js:262:3
async*run_next_test/_run_next_test/<@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:22
async*_run_next_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:1436:10
run@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:687:9
_do_main@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:224:3
_execute_test@c:\Projects\mozilla\gecko-dev\testing\xpcshell\head.js:528:5
@-e:1:1

However, it is good on Mac OS. Also, I would like to know how to verify if this crash report works. I was trying to call MOZ_CRASH() at VR process or GPU process and put breakpoints in CrashReporterHost.cpp at the parent process. But I didn't get any events about the report. Even typing about::crashes, I still didn't see any reports. I notice I can get VRChild::ActorDestroy() for generating the crash report, but in TakeCrashedChildMinidump(), it returns false. It seems like I didn't enable the CrashReporter::TakeMinidumpForChild(). Could you tell me have to generate this mini dump?

Thanks,