Bug 1518895 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Gabriele Svelto [:gsvelto] from comment #8)

> Just tested the patch and the tests run fine in my Windows build.

How do you run the test? and be interested in the configs in your .mozconfig.

I run `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` still gets fail after applying my patches.

I am using Windows Process Explorer to kill processes.

After calling ./mach run --enable-crash-reporter and kill GPU or VR process, it enables CrashReporter::TakeMinidumpForChild() but still has no data at ChildProcessData* pd = pidToMinidump->GetEntry(childPid).

Reproduce steps:
1. ./mach run --enable-crash-reporter on Windows
2. Go to https://webvr.info/samples/04-simple-mirroring.html, you will see a VR process is launched.
3. Using MSVC debugger or gdb to attach the parent process.
4. Kill VR process in Process Explorer.
Revision 1 by
on 
(In reply to Gabriele Svelto [:gsvelto] from comment #8)

> Just tested the patch and the tests run fine in my Windows build.

How do you run the test? and be interested in the configs in your .mozconfig.

I run `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` still gets fail after applying my patches.

I am using Windows Process Explorer to kill processes.

After calling ./mach run --enable-crash-reporter and kill GPU or VR process, it enables CrashReporter::TakeMinidumpForChild() but still has no data at ChildProcessData* pd = pidToMinidump->GetEntry(childPid).

Reproduce steps:
1. ./mach run --enable-crash-reporter on Windows
2. Go to https://webvr.info/samples/04-simple-mirroring.html, you will see a VR process is launched.
3. Using MSVC debugger or gdb to attach the parent process.
4. Kill VR process in Process Explorer.
5. The breakpoint will be triggered at CrashReporter::TakeMinidumpForChild() in the parent process.
Revision 2 by
on 
(In reply to Gabriele Svelto [:gsvelto] from comment #8)

> Just tested the patch and the tests run fine in my Windows build.

How do you run the test? and be interested in the configs in your .mozconfig.

I run `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` still gets fail after applying my patches.

I am using Windows Process Explorer to kill processes.

After calling ./mach run --enable-crash-reporter and kill GPU or VR process, it enables CrashReporter::TakeMinidumpForChild() but still has no data at `ChildProcessData* pd = pidToMinidump->GetEntry(childPid)`.

Reproduce steps:
1. ./mach run --enable-crash-reporter on Windows
2. Go to https://webvr.info/samples/04-simple-mirroring.html, you will see a VR process is launched.
3. Using MSVC debugger or gdb to attach the parent process.
4. Kill VR process in Process Explorer.
5. The breakpoint will be triggered at CrashReporter::TakeMinidumpForChild() in the parent process.
Revision 3 by
on 
(In reply to Gabriele Svelto [:gsvelto] from comment #8)

> Just tested the patch and the tests run fine in my Windows build.

How do you run the test? and be interested in the configs in your .mozconfig.

I run `./mach test toolkit/components/crashes/tests/xpcshell/test_crash_manager.js` still gets fail after applying my patches.

I am using Windows Process Explorer to kill processes.

After calling `./mach run --enable-crash-reporter` and kill GPU or VR process, it enables CrashReporter::TakeMinidumpForChild() but still has no data at `ChildProcessData* pd = pidToMinidump->GetEntry(childPid)`.

Reproduce steps:
1. ./mach run --enable-crash-reporter on Windows
2. Go to https://webvr.info/samples/04-simple-mirroring.html, you will see a VR process is launched.
3. Using MSVC debugger or gdb to attach the parent process.
4. Kill VR process in Process Explorer.
5. The breakpoint will be triggered at CrashReporter::TakeMinidumpForChild() in the parent process.

Back to Bug 1518895 Comment 9