Bug 1519546 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hi Cameron,

I have a question about when to update the frame transform for this step in this bug:

> When the transform from an embedding element (e.g. iframe) to its docs root element changes, send a message to the chrome process using BrowserBridgeChild notifying it of the new transform

It seems we have to send the transform update to chrome process when:
1. First paint
2. Any style change on transform or geometric updates.

Basically, this frame transform is used for painting, after we calculating the frame tree. At first, I thought maybe somewhere in `RestyleManager`, but I'm not familiar with this, and the timing may not be correct. Therefore, I may need your suggestions where are the suitable functions to send the IPC messages (i.e. update the frame transform in TabChild). Thanks.
Hi Cameron,

I have a question about when to update the frame transform for this step in this bug:

> When the transform from an embedding element (e.g. iframe) to its docs root element changes, send a message to the chrome process using BrowserBridgeChild notifying it of the new transform

It seems we have to send the transform update to chrome process when:
1. First paint
2. Any style change on transform or geometric updates.
3. Reflow?

Basically, this frame transform is used for painting, after we calculating the frame tree. At first, I thought maybe somewhere in `RestyleManager`, but I'm not familiar with this, and the timing may not be correct. Therefore, I may need your suggestions where are the suitable functions to send the IPC messages (i.e. update the frame transform in TabChild). Thanks.

Back to Bug 1519546 Comment 12