Yes, we would have to move the following into the docker image: [1] With that change, we would also need to rebuild the docker image any time we rerun the custom-v8 task by updating this function: [2] I don't see anything obvious in the dependencies script [3] that would require us to also run it in the v8 build task so there shouldn't be any issues if it's completely removed from [1]. [1]: https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/build-custom-v8.sh#26-41 [2]: https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#571-573 [3]: https://chromium.googlesource.com/chromium/src/+/HEAD/build/install-build-deps.sh
Bug 1519816 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Yes, we would have to move the following into the docker image: [link1] With that change, we would also need to rebuild the docker image any time we rerun the custom-v8 task by updating this function: [link2] I don't see anything obvious in the dependencies script [link3] that would require us to also run it in the v8 build task so there shouldn't be any issues if it's completely removed from [link1]. [link1]: https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/build-custom-v8.sh#26-41 [link2]: https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#571-573 [link3]: https://chromium.googlesource.com/chromium/src/+/HEAD/build/install-build-deps.sh