Bug 1520321 Comment 23 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I just did a couple of manual tests using a build from
https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-03-23-58-37-oak/

I replaced the crashreporter.exe in the oak install with one from m-c to cause the partial update to fail.

I noticed the following minor issue in the browser console.
AUS:SVC handleFallbackToCompleteUpdate - install of partial patch failed, downloading complete patch

There was a major issue in that the even though the partial was then downloaded using nsIIncrementalDownload when the partial failed again it didn't try to download the complete update using BITS. The about dialog continued to display "Applying" until I closed it and reopened it again. Also, the xml contained some information for the complete patch that should have been for the partial patch. 

<?xml version="1.0"?><updates xmlns="http://www.mozilla.org/2005/app-update"><update xmlns="http://www.mozilla.org/2005/app-update" appVersion="68.0a1" buildID="20190404220925" channel="nightly-oak" detailsURL="https://www.mozilla.org/en-US/firefox/nightly/notes/" displayVersion="68.0a1" installDate="1554438897830" isCompleteUpdate="false" name="Nightly 68.0a1" previousAppVersion="68.0a1" promptWaitTime="43200" serviceURL="https://aus5.mozilla.org/update/6/Firefox/68.0a1/20190403235837/WINNT_x86_64-msvc-x64/en-US/nightly-oak/Windows_NT%2010.0.0.0.17763.379%20(x64)/ISET:SSE4_2,MEM:32620/default/default/update.xml?force=1" type="minor" statusText="Install Pending" platformVersion="68.0a1" foregroundDownload="true" patchingFailed="partial" stagingFailed="true"><patch size="51578648" type="complete" URL="https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-04-22-09-25-oak/firefox-68.0a1.en-US.win64.complete.mar" hashFunction="sha512" hashValue="6d5f3040a80a7276b8dd53f1050e1ed9d26921d59dba4e81a5590b9f48f005b9f5174e3cd0710b50a503032be6ae763750faa09146d251d4331d97616db9155e"/><patch size="10751771" type="partial" URL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" errorCode="2" finalURL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" selected="true" state="pending-service" hashFunction="sha512" hashValue="f3339c186d25b8089c49a9ff3c7d8c176bec9c7f99ffc69487c75315dd9181105cab1fc585b1f2c10e5a520e1f25cc4945b49f65252d383db24ca3c1e8425b69" bitsId="{8E9F0DFF-1A67-4590-91B6-22BFEB3F65C1}" bitsResult="0" nonbitsResult="0"/></update>

I'll attach the browser console log as well
Revision 1 by
on 
I just did a couple of manual tests using a build from
https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-03-23-58-37-oak/

I replaced the crashreporter.exe in the oak install with one from m-c to cause the partial update to fail.

I noticed the following minor issue in the browser console.
AUS:SVC handleFallbackToCompleteUpdate - install of partial patch failed, downloading complete patch

There was a major issue in that the even though the partial was then downloaded using nsIIncrementalDownload when the partial failed again it didn't try to download the complete update using BITS. The about dialog continued to display "Applying" until I closed it and reopened it again. Also, the xml contained some information for the complete patch that should have been for the partial patch. *edit* bytesized pointed out that the xml doesn't contain "some information for the complete patch that should have been for the partial patch".

<?xml version="1.0"?><updates xmlns="http://www.mozilla.org/2005/app-update"><update xmlns="http://www.mozilla.org/2005/app-update" appVersion="68.0a1" buildID="20190404220925" channel="nightly-oak" detailsURL="https://www.mozilla.org/en-US/firefox/nightly/notes/" displayVersion="68.0a1" installDate="1554438897830" isCompleteUpdate="false" name="Nightly 68.0a1" previousAppVersion="68.0a1" promptWaitTime="43200" serviceURL="https://aus5.mozilla.org/update/6/Firefox/68.0a1/20190403235837/WINNT_x86_64-msvc-x64/en-US/nightly-oak/Windows_NT%2010.0.0.0.17763.379%20(x64)/ISET:SSE4_2,MEM:32620/default/default/update.xml?force=1" type="minor" statusText="Install Pending" platformVersion="68.0a1" foregroundDownload="true" patchingFailed="partial" stagingFailed="true"><patch size="51578648" type="complete" URL="https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-04-22-09-25-oak/firefox-68.0a1.en-US.win64.complete.mar" hashFunction="sha512" hashValue="6d5f3040a80a7276b8dd53f1050e1ed9d26921d59dba4e81a5590b9f48f005b9f5174e3cd0710b50a503032be6ae763750faa09146d251d4331d97616db9155e"/><patch size="10751771" type="partial" URL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" errorCode="2" finalURL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" selected="true" state="pending-service" hashFunction="sha512" hashValue="f3339c186d25b8089c49a9ff3c7d8c176bec9c7f99ffc69487c75315dd9181105cab1fc585b1f2c10e5a520e1f25cc4945b49f65252d383db24ca3c1e8425b69" bitsId="{8E9F0DFF-1A67-4590-91B6-22BFEB3F65C1}" bitsResult="0" nonbitsResult="0"/></update>

I'll attach the browser console log as well
Revision 2 by
on 
I just did a couple of manual tests using a build from
https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-03-23-58-37-oak/

I replaced the crashreporter.exe in the oak install with one from m-c to cause the partial update to fail.

I noticed the following minor issue in the browser console.
AUS:SVC handleFallbackToCompleteUpdate - install of partial patch failed, downloading complete patch

There was a major issue in that the even though the partial was then downloaded using nsIIncrementalDownload when the partial failed again it didn't try to download the complete update using BITS. The about dialog continued to display "Applying" until I closed it and reopened it again. Also, the xml contained some information for the complete patch that should have been for the partial patch. **edit** bytesized pointed out that the xml doesn't contain "some information for the complete patch that should have been for the partial patch".

<?xml version="1.0"?><updates xmlns="http://www.mozilla.org/2005/app-update"><update xmlns="http://www.mozilla.org/2005/app-update" appVersion="68.0a1" buildID="20190404220925" channel="nightly-oak" detailsURL="https://www.mozilla.org/en-US/firefox/nightly/notes/" displayVersion="68.0a1" installDate="1554438897830" isCompleteUpdate="false" name="Nightly 68.0a1" previousAppVersion="68.0a1" promptWaitTime="43200" serviceURL="https://aus5.mozilla.org/update/6/Firefox/68.0a1/20190403235837/WINNT_x86_64-msvc-x64/en-US/nightly-oak/Windows_NT%2010.0.0.0.17763.379%20(x64)/ISET:SSE4_2,MEM:32620/default/default/update.xml?force=1" type="minor" statusText="Install Pending" platformVersion="68.0a1" foregroundDownload="true" patchingFailed="partial" stagingFailed="true"><patch size="51578648" type="complete" URL="https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-04-22-09-25-oak/firefox-68.0a1.en-US.win64.complete.mar" hashFunction="sha512" hashValue="6d5f3040a80a7276b8dd53f1050e1ed9d26921d59dba4e81a5590b9f48f005b9f5174e3cd0710b50a503032be6ae763750faa09146d251d4331d97616db9155e"/><patch size="10751771" type="partial" URL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" errorCode="2" finalURL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" selected="true" state="pending-service" hashFunction="sha512" hashValue="f3339c186d25b8089c49a9ff3c7d8c176bec9c7f99ffc69487c75315dd9181105cab1fc585b1f2c10e5a520e1f25cc4945b49f65252d383db24ca3c1e8425b69" bitsId="{8E9F0DFF-1A67-4590-91B6-22BFEB3F65C1}" bitsResult="0" nonbitsResult="0"/></update>

I'll attach the browser console log as well
Revision 3 by
on 
I just did a couple of manual tests using a build from
https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-03-23-58-37-oak/

I replaced the crashreporter.exe in the oak install with one from m-c to cause the partial update to fail.

I noticed the following minor issue in the browser console.
AUS:SVC handleFallbackToCompleteUpdate - install of partial patch failed, downloading complete patch

There was a major issue in that the even though the partial was then downloaded using nsIIncrementalDownload when the partial failed again it didn't try to download the complete update using BITS. The about dialog continued to display "Applying" until I closed it and reopened it again. Also, the xml contained some information for the complete patch that should have been for the partial patch.
**EDIT** bytesized pointed out that the xml doesn't contain "some information for the complete patch that should have been for the partial patch".

<?xml version="1.0"?><updates xmlns="http://www.mozilla.org/2005/app-update"><update xmlns="http://www.mozilla.org/2005/app-update" appVersion="68.0a1" buildID="20190404220925" channel="nightly-oak" detailsURL="https://www.mozilla.org/en-US/firefox/nightly/notes/" displayVersion="68.0a1" installDate="1554438897830" isCompleteUpdate="false" name="Nightly 68.0a1" previousAppVersion="68.0a1" promptWaitTime="43200" serviceURL="https://aus5.mozilla.org/update/6/Firefox/68.0a1/20190403235837/WINNT_x86_64-msvc-x64/en-US/nightly-oak/Windows_NT%2010.0.0.0.17763.379%20(x64)/ISET:SSE4_2,MEM:32620/default/default/update.xml?force=1" type="minor" statusText="Install Pending" platformVersion="68.0a1" foregroundDownload="true" patchingFailed="partial" stagingFailed="true"><patch size="51578648" type="complete" URL="https://archive.mozilla.org/pub/firefox/nightly/2019/04/2019-04-04-22-09-25-oak/firefox-68.0a1.en-US.win64.complete.mar" hashFunction="sha512" hashValue="6d5f3040a80a7276b8dd53f1050e1ed9d26921d59dba4e81a5590b9f48f005b9f5174e3cd0710b50a503032be6ae763750faa09146d251d4331d97616db9155e"/><patch size="10751771" type="partial" URL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" errorCode="2" finalURL="https://archive.mozilla.org/pub/firefox/nightly/partials/2019/04/2019-04-04-22-09-25-oak/firefox-oak-68.0a1-win64-en-US-20190403235837-20190404220925.partial.mar" selected="true" state="pending-service" hashFunction="sha512" hashValue="f3339c186d25b8089c49a9ff3c7d8c176bec9c7f99ffc69487c75315dd9181105cab1fc585b1f2c10e5a520e1f25cc4945b49f65252d383db24ca3c1e8425b69" bitsId="{8E9F0DFF-1A67-4590-91B6-22BFEB3F65C1}" bitsResult="0" nonbitsResult="0"/></update>

I'll attach the browser console log as well

Back to Bug 1520321 Comment 23