Bug 1520806 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I wasn't able to test this codepath from mozilla-central (or at least, I couldn't figure out how to test it), so I did this as a commit to the wpt repo on github.

I think this does what we want it to do:

I'm able to access browser_channel from https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py#311 and should omit the unittest-features profile from pref_paths if browser_channel is not 'nightly' (which I think the only options are 'nightly' and 'stable', with a bunch of aliases for other browsers?). 

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel nightly` it runs the test successfully as expected, since all of the profiles are included.

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel stable` it hangs for many minutes after printing "Running 1 tests in web-platform-tests", eventually printing these stack traces: https://gist.github.com/KWierso/af18fc662644b60c80ef250853ccbb1d

I'm guessing release Firefox isn't configured out of the box with marionette support? Is that a compile-time thing, or is there a pref we can set in the unittest-stability or web-platform pref profiles to flip it on?



Here's the commit: https://github.com/KWierso/wpt/commit/c935d6d00edd6c893c17545e7c886fd5d3ce72c1?diff=unified

If this looks correct or at least along the lines I need to proceed, I can either submit this as a PR to the github repo or port it over to m-c and push it to phabricator for review, whichever works better for you.
I wasn't able to test this codepath from mozilla-central (or at least, I couldn't figure out how to test it), so I did this as a commit to the wpt repo on github.

I think this does what we want it to do:

I'm able to access browser_channel from https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py#311 and it should now omit the unittest-features profile from pref_paths if browser_channel is not 'nightly' (which I think the only options are 'nightly' and 'stable', with a bunch of aliases for other browsers?). 

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel nightly` it runs the test successfully as expected, since all of the profiles are included.

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel stable` it hangs for many minutes after printing "Running 1 tests in web-platform-tests", eventually printing these stack traces: https://gist.github.com/KWierso/af18fc662644b60c80ef250853ccbb1d

I'm guessing release Firefox isn't configured out of the box with marionette support? Is that a compile-time thing, or is there a pref we can set in the unittest-stability or web-platform pref profiles to flip it on?



Here's the commit: https://github.com/KWierso/wpt/commit/c935d6d00edd6c893c17545e7c886fd5d3ce72c1?diff=unified

If this looks correct or at least along the lines I need to proceed, I can either submit this as a PR to the github repo or port it over to m-c and push it to phabricator for review, whichever works better for you.
I wasn't able to test this codepath from mozilla-central (or at least, I couldn't figure out how to test it), so I did this as a commit to the wpt repo on github.

I think this does what we want it to do:

I'm able to access browser_channel from https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox.py#311 and it should now omit the unittest-features profile from pref_paths if browser_channel is not 'nightly' (which I think the only options are 'nightly' and 'stable', with a bunch of aliases for other browsers, plus 'None' when invoked via mach?). 

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel nightly` it runs the test successfully as expected, since all of the profiles are included.

When I run `./wpt run firefox pointerevents/pointerevent_pointermove.html --log-mach ~/Desktop/wptrun.log --browser-channel stable` it hangs for many minutes after printing "Running 1 tests in web-platform-tests", eventually printing these stack traces: https://gist.github.com/KWierso/af18fc662644b60c80ef250853ccbb1d

I'm guessing release Firefox isn't configured out of the box with marionette support? Is that a compile-time thing, or is there a pref we can set in the unittest-stability or web-platform pref profiles to flip it on?



Here's the commit: https://github.com/KWierso/wpt/commit/c935d6d00edd6c893c17545e7c886fd5d3ce72c1?diff=unified

If this looks correct or at least along the lines I need to proceed, I can either submit this as a PR to the github repo or port it over to m-c and push it to phabricator for review, whichever works better for you.

Back to Bug 1520806 Comment 4