Bug 1523439 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I cleaned up my own notes that I had on the consumers of this method:

nsDisplayPerspective::CreateWebRenderCommands:

  mattwoodrow says this should not be using the cross-document variant
  of this function.  I think we could fix this as part of bug 1523500
  (I mentioned it over there in bug 1523500 comment 5).

nsIPresShell::ClearMouseCapture:

  Covered by bug 1533499.

nsRootPresContext::ComputePluginGeometryUpdates

  Covered by bug 1518911.

GetClosest in PositionedEventTarget.cpp:

  Henri/Botond are working on making sure that events go to the correct process
  using the APZ code, so this reaching across document boundaries should be
  okay at that point.

DOMIntersectionObserver::Update:

  This is fine. Script can't observe elements that it can't reach (i.e. anything
  cross-document would need to belong to the same origin etc.). The exception to
  that is when script passes 'null' to observe intersection with the root
  viewport.

nsLayoutUtils::IsProperAncestorFrameCrossDoc

  No issues - see comment 1.
I cleaned up my own notes that I had on the consumers of this method:

nsDisplayPerspective::CreateWebRenderCommands:

  mattwoodrow says this should not be using the cross-document variant
  of this function.  I think we could fix this as part of bug 1523500
  (I mentioned it over there in bug 1523500 comment 5).

nsIPresShell::ClearMouseCapture:

  Covered by bug 1533499.

nsRootPresContext::ComputePluginGeometryUpdates

  Covered by bug 1525720.

GetClosest in PositionedEventTarget.cpp:

  Henri/Botond are working on making sure that events go to the correct process
  using the APZ code, so this reaching across document boundaries should be
  okay at that point.

DOMIntersectionObserver::Update:

  This is fine. Script can't observe elements that it can't reach (i.e. anything
  cross-document would need to belong to the same origin etc.). The exception to
  that is when script passes 'null' to observe intersection with the root
  viewport.

nsLayoutUtils::IsProperAncestorFrameCrossDoc

  No issues - see comment 1.
I cleaned up my own notes that I had on the consumers of this method:

nsDisplayPerspective::CreateWebRenderCommands:

  mattwoodrow says this should not be using the cross-document variant
  of this function.  I think we could fix this as part of bug 1523500
  (I mentioned it over there in bug 1523500 comment 5).

nsIPresShell::ClearMouseCapture:

  Covered by bug 1533499.

nsRootPresContext::ComputePluginGeometryUpdates:

  Covered by bug 1525720?

GetClosest in PositionedEventTarget.cpp:

  Henri/Botond are working on making sure that events go to the correct process
  using the APZ code, so this reaching across document boundaries should be
  okay at that point.

DOMIntersectionObserver::Update:

  This is fine. Script can't observe elements that it can't reach (i.e. anything
  cross-document would need to belong to the same origin etc.). The exception to
  that is when script passes 'null' to observe intersection with the root
  viewport.

nsLayoutUtils::IsProperAncestorFrameCrossDoc

  No issues - see comment 1.

Back to Bug 1523439 Comment 3