Bug 1523791 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Jason Orendorff [:jorendorff] from comment #2)
> ::: js/src/frontend/BytecodeEmitter.cpp
> @@ +7671,3 @@
> >        //            [stack] CTOR? OBJ CTOR? KEY?
> >  
> > +      if (propVal->isDirectRHSAnonFunction()) {
> 
> Maybe we should get rid of the bit that stores this and recompute it each
> time this is called (at most once per node, I think). Let me know if you
> think so, I can file a followup bug...
> 

We need to have a separate bit, because constant folding may have changed the parse tree, so it's no longer possible to decide if function name inference has to applied when we're in BytecodeEmitter → bug 883377 comment #41. :-)
Revision 1 by
on 
(In reply to Jason Orendorff [:jorendorff] from comment #2)
> ::: js/src/frontend/BytecodeEmitter.cpp
> @@ +7671,3 @@
> >        //            [stack] CTOR? OBJ CTOR? KEY?
> >  
> > +      if (propVal->isDirectRHSAnonFunction()) {
> 
> Maybe we should get rid of the bit that stores this and recompute it each
> time this is called (at most once per node, I think). Let me know if you
> think so, I can file a followup bug...
> 

We need to have a separate bit, because constant folding may have changed the parse tree, so it's no longer possible to decide if function name inference has to applied when we're in BytecodeEmitter → bug 883377 comment #41.

Back to Bug 1523791 Comment 3