(In reply to Byron Campen [:bwc] from comment #19) > (In reply to Nico Grunbaum [:ng] from comment #16) > > > Disassembling the libxul.so in the build artifact and looking at the addresses in some of the failures reveals, has so far revealed two failures: [1], [2]. > > [1] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1841 On transceiver->() > > [2] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#2997 > > So [1] isn't a UniquePtr, so that's a separate problem. As for [2], that is at least in a place that bug 1494311 touched, but it seems to use std::unique_ptr and not UniquePtr, which is weird. In [2] `query` is a UniqPtr, this (`595ca43`) is the failure site: ```Cpp-ObjDump 3761993- 595ca22: e8 bb 9a 93 ff callq 52964e2 <RefPtr<mozilla::MediaTransportHandler>::operator->() const> 3761994- 595ca27: 48 89 c3 mov %rax,%rbx 3761995- 595ca2a: 48 8b 00 mov (%rax),%rax 3761996- 595ca2d: 4c 89 ff mov %r15,%rdi 3761997- 595ca30: 48 ff 05 d1 8a b1 0e incq 0xeb18ad1(%rip) # 14475508 <__gcov0._ZN7mozilla18PeerConnectionImpl19ExecuteStatsQuery_sEONS_9UniquePtrINS_13RTCStatsQueryENS_13DefaultDeleteIS2_EEEERK8nsTArrayI6RefPtrINS_13MediaPipelineEEERKS8_INS_21MediaTransportHandlerEE+0x528> 3761998- 595ca37: 4c 8b a8 80 00 00 00 mov 0x80(%rax),%r13 3761999- 595ca3e: e8 95 31 fd ff callq 592fbd8 <mozilla::UniquePtr<mozilla::RTCStatsQuery, mozilla::DefaultDelete<mozilla::RTCStatsQuery> >::operator->() const> 3762000: 595ca43: 48 8d 8d a0 fd ff ff lea -0x260(%rbp),%rcx 3762001- 595ca4a: 48 ff 05 bf 8a b1 0e incq 0xeb18abf(%rip) # 14475510 ```
Bug 1523795 Comment 20 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Byron Campen [:bwc] from comment #19) > (In reply to Nico Grunbaum [:ng] from comment #16) > > > Disassembling the libxul.so in the build artifact and looking at the addresses in some of the failures reveals, has so far revealed two failures: [1], [2]. > > [1] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1841 On transceiver->() > > [2] https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#2997 > > So [1] isn't a UniquePtr, so that's a separate problem. As for [2], that is at least in a place that bug 1494311 touched, but it seems to use std::unique_ptr and not UniquePtr, which is weird. In [2] `query` is a UniqPtr, this (`595ca43`) is the failure site (excerpt from the attached dump): ```Cpp-ObjDump 3761993- 595ca22: e8 bb 9a 93 ff callq 52964e2 <RefPtr<mozilla::MediaTransportHandler>::operator->() const> 3761994- 595ca27: 48 89 c3 mov %rax,%rbx 3761995- 595ca2a: 48 8b 00 mov (%rax),%rax 3761996- 595ca2d: 4c 89 ff mov %r15,%rdi 3761997- 595ca30: 48 ff 05 d1 8a b1 0e incq 0xeb18ad1(%rip) # 14475508 <__gcov0._ZN7mozilla18PeerConnectionImpl19ExecuteStatsQuery_sEONS_9UniquePtrINS_13RTCStatsQueryENS_13DefaultDeleteIS2_EEEERK8nsTArrayI6RefPtrINS_13MediaPipelineEEERKS8_INS_21MediaTransportHandlerEE+0x528> 3761998- 595ca37: 4c 8b a8 80 00 00 00 mov 0x80(%rax),%r13 3761999- 595ca3e: e8 95 31 fd ff callq 592fbd8 <mozilla::UniquePtr<mozilla::RTCStatsQuery, mozilla::DefaultDelete<mozilla::RTCStatsQuery> >::operator->() const> 3762000: 595ca43: 48 8d 8d a0 fd ff ff lea -0x260(%rbp),%rcx 3762001- 595ca4a: 48 ff 05 bf 8a b1 0e incq 0xeb18abf(%rip) # 14475510 ```